-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Refactor hll_sketch and fix stack use after return bug #50600
Merged
kangkaisen
merged 3 commits into
StarRocks:main
from
LiShuMing:fix/main/fix_hll_sketch_bugs
Sep 3, 2024
Merged
[Enhancement] Refactor hll_sketch and fix stack use after return bug #50600
kangkaisen
merged 3 commits into
StarRocks:main
from
LiShuMing:fix/main/fix_hll_sketch_bugs
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
LiShuMing
force-pushed
the
fix/main/fix_hll_sketch_bugs
branch
from
September 3, 2024 02:19
57e0b09
to
2365e1b
Compare
LiShuMing
changed the title
[Enhancement] Refactor hll_sktch and fix stack use after free bug
[Enhancement] Refactor hll_sktch and fix stack use after return bug
Sep 3, 2024
Signed-off-by: shuming.li <[email protected]>
silverbullet233
approved these changes
Sep 3, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 160 / 250 (64.00%) file detail
|
meegoo
approved these changes
Sep 3, 2024
satanson
approved these changes
Sep 3, 2024
va-os-commits
pushed a commit
to va-os-commits/starrocks
that referenced
this pull request
Sep 10, 2024
…tarRocks#50600) Signed-off-by: shuming.li <[email protected]>
chaoyli
changed the title
[Enhancement] Refactor hll_sktch and fix stack use after return bug
[Enhancement] Refactor hll_sketch and fix stack use after return bug
Sep 26, 2024
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…tarRocks#50600) Signed-off-by: shuming.li <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Possible
stack-use-after-return
:What I'm doing:
hll_sketch
fromhll.h
since it will cost too much time oncehll.h
has changed.hll_skecth.h
aggregate function tods_hll_count_distinct.h
stack after return
bug by pinningmemory_usage
pointer.Fixes #49000
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: