-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] fix analyzing error in prepare stmt with HAVING clause #50583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaoxunLi
force-pushed
the
group_by_in_prepare_stmt
branch
4 times, most recently
from
September 3, 2024 02:27
32085a3
to
2f0fcd2
Compare
ShaoxunLi
force-pushed
the
group_by_in_prepare_stmt
branch
3 times, most recently
from
September 9, 2024 14:18
09e6489
to
b318f37
Compare
Signed-off-by: ShaoxunLi <[email protected]>
ShaoxunLi
force-pushed
the
group_by_in_prepare_stmt
branch
from
September 9, 2024 15:05
b318f37
to
963c87a
Compare
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
ShaoxunLi
changed the title
[BugFix] fix analyzing error in prepare stmt with "HAVING COUNT(*) = ?"
[BugFix] fix analyzing error in prepare stmt with HAVING clause
Sep 12, 2024
packy92
approved these changes
Sep 20, 2024
Seaven
approved these changes
Sep 23, 2024
trueeyu
approved these changes
Sep 23, 2024
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Signed-off-by: ShaoxunLi <[email protected]> (cherry picked from commit e4d19f6)
24 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 23, 2024
…port #50583) (#51258) Co-authored-by: ShaoxunLi <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…Rocks#50583) Signed-off-by: ShaoxunLi <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
The following prepare statement fails to be executed :
What I'm doing:
the aggregation type will not be verified when the expression is a parameter,
Fixes #50584
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: