Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix analyzing error in prepare stmt with HAVING clause #50583

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ShaoxunLi
Copy link
Contributor

@ShaoxunLi ShaoxunLi commented Sep 2, 2024

Why I'm doing:

The following prepare statement fails to be executed :

starrocks> show variables like 'sql_mode';
+---------------+-------+
| Variable_name | Value |
+---------------+-------+
| sql_mode      |       |
+---------------+-------+
1 row in set (0.00 sec)

starrocks> prepare stmt1 from select a from t group by a having count(*) = ?;
ERROR 1064 (HY000): Getting analyzing error. Detail message: ? must appear in the GROUP BY clause or be used in an aggregate function.

starrocks> prepare pp from select a, b from t group by a, b having a > ?;
ERROR 1064 (HY000): Getting analyzing error. Detail message: ? must appear in the GROUP BY clause or be used in an aggregate function.

What I'm doing:

the aggregation type will not be verified when the expression is a parameter,

starrocks> prepare stmt1 from select a from t group by a having count(*) = ?;
Query OK, 0 rows affected (0.00 sec)

starrocks> set @p1 = 1;
Query OK, 0 rows affected (0.01 sec)

starrocks> execute stmt1 using @p1 ;
+------+
| a    |
+------+
|    2 |
|    1 |
+------+
2 rows in set (0.02 sec)
starrocks> prepare pp from select a from t group by a having a > ?;
Query OK, 0 rows affected (0.00 sec)

starrocks> set @p1 = 1;
Query OK, 0 rows affected (0.01 sec)

starrocks> execute pp using @p1;
+------+
| a    |
+------+
|    2 |
+------+
1 row in set (0.03 sec)

Fixes #50584

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@ShaoxunLi ShaoxunLi requested a review from a team as a code owner September 2, 2024 13:03
@ShaoxunLi ShaoxunLi force-pushed the group_by_in_prepare_stmt branch 4 times, most recently from 32085a3 to 2f0fcd2 Compare September 3, 2024 02:27
@ShaoxunLi ShaoxunLi closed this Sep 3, 2024
@ShaoxunLi ShaoxunLi reopened this Sep 6, 2024
@ShaoxunLi ShaoxunLi closed this Sep 6, 2024
@ShaoxunLi ShaoxunLi reopened this Sep 7, 2024
@ShaoxunLi ShaoxunLi force-pushed the group_by_in_prepare_stmt branch 3 times, most recently from 09e6489 to b318f37 Compare September 9, 2024 14:18
Copy link

sonarcloud bot commented Sep 9, 2024

Copy link

github-actions bot commented Sep 9, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 9, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 9, 2024

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/AggregationAnalyzer.java 2 2 100.00% []

@ShaoxunLi ShaoxunLi changed the title [BugFix] fix analyzing error in prepare stmt with "HAVING COUNT(*) = ?" [BugFix] fix analyzing error in prepare stmt with HAVING clause Sep 12, 2024
@ShaoxunLi
Copy link
Contributor Author

ShaoxunLi commented Sep 13, 2024

@Seaven @wyb Can you review this PR? Thank you.

@Seaven Seaven enabled auto-merge (squash) September 23, 2024 02:21
@Seaven Seaven merged commit e4d19f6 into StarRocks:main Sep 23, 2024
79 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 23, 2024
Copy link
Contributor

mergify bot commented Sep 23, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 23, 2024
wanpengfei-git pushed a commit that referenced this pull request Sep 23, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

analyzing error in prepare stmt with "HAVING COUNT(*) = ?"
4 participants