Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix wrong plan when duplicate alias is same as the column name #50566

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

packy92
Copy link
Contributor

@packy92 packy92 commented Sep 2, 2024

Why I'm doing:

after #43919, the sql in the image yields a wrong plan.
img_v3_02eb_7acf65dd-21bd-4fd7-8fa6-1d3c849353bg

What I'm doing:

Even when alias name is same as the column name, we need add it into the aliases map then the next duplicate alias can be added into aliasesMaybeAmbiguous map.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@packy92 packy92 requested a review from a team as a code owner September 2, 2024 11:12
@mergify mergify bot assigned packy92 Sep 2, 2024
Copy link

sonarcloud bot commented Sep 2, 2024

@packy92 packy92 enabled auto-merge (squash) September 2, 2024 11:44
Copy link

github-actions bot commented Sep 2, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 2, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

@packy92 packy92 merged commit 509a75f into StarRocks:main Sep 2, 2024
52 of 53 checks passed
Copy link

github-actions bot commented Sep 2, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

va-os-commits pushed a commit to va-os-commits/starrocks that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants