Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] support more pushdown functions #50559

Merged
merged 3 commits into from
Sep 2, 2024
Merged

[Enhancement] support more pushdown functions #50559

merged 3 commits into from
Sep 2, 2024

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Sep 2, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Pushdown more functions in Project under the Join node.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@murphyatwork murphyatwork requested a review from a team as a code owner September 2, 2024 09:23
@murphyatwork
add test
74a07e1 
Signed-off-by: Murphy <[email protected]>
Seaven
Seaven previously approved these changes Sep 2, 2024
View reviewed changes
packy92
packy92 previously approved these changes Sep 2, 2024
View reviewed changes
@murphyatwork
fix test
35c7b5b 
Signed-off-by: Murphy <[email protected]>
@murphyatwork murphyatwork dismissed stale reviews from packy92 and Seaven via 35c7b5b September 2, 2024 10:39
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

[FE Incremental Coverage Report]

✅ pass : 16 / 19 (84.21%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/tree/prunesubfield/SubfieldExpressionCollector.java 6 9 66.67% [52, 53, 54]
🔵 com/starrocks/sql/optimizer/rule/tree/prunesubfield/SubfieldAccessPathNormalizer.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/rule/tree/prunesubfield/PushDownSubfieldRule.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/rule/tree/prunesubfield/PruneSubfieldRule.java 8 8 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@murphyatwork murphyatwork merged commit 66e314a into StarRocks:main Sep 2, 2024
55 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 2, 2024
@murphyatwork @mergify
[Enhancement] support more pushdown functions (#50559)
04d2130 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 66e314a)
@mergify mergify bot mentioned this pull request Sep 2, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 2, 2024
@murphyatwork @mergify
[Enhancement] support more pushdown functions (#50559)
d932e79 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 66e314a)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/prunesubfield/PruneSubfieldRule.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/prunesubfield/SubfieldExpressionCollector.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/LowCardinalityArrayTest.java
@mergify mergify bot mentioned this pull request Sep 2, 2024
Merged
42 tasks
murphyatwork added a commit that referenced this pull request Sep 2, 2024
@murphyatwork
[Enhancement] support more pushdown functions (#50559)
4e9a625 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 66e314a)
Signed-off-by: Murphy <[email protected]>

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/prunesubfield/PruneSubfieldRule.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/prunesubfield/SubfieldExpressionCollector.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/LowCardinalityArrayTest.java
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2024
@mergify @murphyatwork
[Enhancement] support more pushdown functions (backport #50559) (#50579)
2fd1b78 
Co-authored-by: Murphy <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 4, 2024
@mergify @murphyatwork
[Enhancement] support more pushdown functions (backport #50559) (#50578)
fc99c91 
Co-authored-by: Murphy <[email protected]>
xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request Sep 6, 2024
@mergify @murphyatwork @xiangguangyxg
[Enhancement] support more pushdown functions (backport StarRocks#50559…
2e2652d 
…) (StarRocks#50578)

Co-authored-by: Murphy <[email protected]>
va-os-commits pushed a commit to va-os-commits/starrocks that referenced this pull request Sep 10, 2024
@murphyatwork @va-os-commits
[Enhancement] support more pushdown functions (StarRocks#50559)
5164986 
Signed-off-by: Murphy <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@murphyatwork @renzhimin7
[Enhancement] support more pushdown functions (StarRocks#50559)
952ecbb 
Signed-off-by: Murphy <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@trueeyu trueeyu trueeyu approved these changes

@Seaven Seaven Seaven approved these changes

@packy92 packy92 packy92 left review comments

Assignees

@murphyatwork murphyatwork

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murphyatwork @Seaven @trueeyu @packy92