Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] skip add the alias into fieldMapping when order by expr not referenced this alias #50546

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

packy92
Copy link
Contributor

@packy92 packy92 commented Sep 2, 2024

Why I'm doing:

failed to execute select v1 cc, v2 cc from tbl order by v3 with error info column cc is ambiguous

What I'm doing:

order by expr may reference the alias. We need put the alias into the fieldMappings or the expressionToColumns.
if the alias not be used in the order by expr like:
select v1 cc, v2 cc from tbl order by v3
We just add the slotRef(cc) to columnRefOperator in the
expressionToColumns to ensure this projection can output v1 with alias cc, v2 with alias cc and v3.
We don't need to ensure the uniqueness of the alias in the fieldMappings.

if the alias used in the order by expr like:
select v1 v3, v2 cc from (select abs(v1) v1, abs(v2) v2, v3 from t0) t1 order by t1.v3
order by expr t1.v3 referenced the v1 with alias v3, we need set the fieldMappings to ensure order by
expr can be resolved.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@packy92 packy92 requested a review from a team as a code owner September 2, 2024 07:35
Signed-off-by: packy92 <[email protected]>
Copy link

sonarcloud bot commented Sep 2, 2024

Copy link

github-actions bot commented Sep 2, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 2, 2024

[FE Incremental Coverage Report]

pass : 13 / 13 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/transformer/QueryTransformer.java 13 13 100.00% []

Copy link

github-actions bot commented Sep 2, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@packy92 packy92 merged commit 885c500 into StarRocks:main Sep 2, 2024
55 checks passed
Copy link

github-actions bot commented Sep 2, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

@Mergifyio backport branch-3.1

Copy link

github-actions bot commented Sep 2, 2024

@Mergifyio backport branch-2.5

Copy link
Contributor

mergify bot commented Sep 2, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 2, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 2, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 2, 2024

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 2, 2024
…referenced this alias (#50546)

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 885c500)
mergify bot pushed a commit that referenced this pull request Sep 2, 2024
…referenced this alias (#50546)

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 885c500)
mergify bot pushed a commit that referenced this pull request Sep 2, 2024
…referenced this alias (#50546)

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 885c500)
mergify bot pushed a commit that referenced this pull request Sep 2, 2024
…referenced this alias (#50546)

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 885c500)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/OrderByTest.java
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2024
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2024
wanpengfei-git pushed a commit that referenced this pull request Sep 4, 2024
xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request Sep 6, 2024
va-os-commits pushed a commit to va-os-commits/starrocks that referenced this pull request Sep 10, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
…referenced this alias (StarRocks#50546)

Signed-off-by: packy92 <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants