-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] skip add the alias into fieldMapping when order by expr not referenced this alias #50546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…referenced this alias Signed-off-by: packy92 <[email protected]>
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/QueryTransformer.java
Show resolved
Hide resolved
Signed-off-by: packy92 <[email protected]>
Quality Gate passedIssues Measures |
kangkaisen
approved these changes
Sep 2, 2024
Seaven
approved these changes
Sep 2, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 13 / 13 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
…referenced this alias (#50546) Signed-off-by: packy92 <[email protected]> (cherry picked from commit 885c500)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
…referenced this alias (#50546) Signed-off-by: packy92 <[email protected]> (cherry picked from commit 885c500)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
…referenced this alias (#50546) Signed-off-by: packy92 <[email protected]> (cherry picked from commit 885c500)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
…referenced this alias (#50546) Signed-off-by: packy92 <[email protected]> (cherry picked from commit 885c500) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/plan/OrderByTest.java
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 2, 2024
…referenced this alias (backport #50546) (#50564) Co-authored-by: packy92 <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 2, 2024
…referenced this alias (backport #50546) (#50563) Co-authored-by: packy92 <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 4, 2024
…referenced this alias (backport #50546) (#50562) Co-authored-by: packy92 <[email protected]>
xiangguangyxg
pushed a commit
to xiangguangyxg/starrocks
that referenced
this pull request
Sep 6, 2024
…referenced this alias (backport StarRocks#50546) (StarRocks#50562) Co-authored-by: packy92 <[email protected]>
va-os-commits
pushed a commit
to va-os-commits/starrocks
that referenced
this pull request
Sep 10, 2024
…referenced this alias (StarRocks#50546) Signed-off-by: packy92 <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…referenced this alias (StarRocks#50546) Signed-off-by: packy92 <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
failed to execute
select v1 cc, v2 cc from tbl order by v3
with error infocolumn cc is ambiguous
What I'm doing:
order by expr may reference the alias. We need put the alias into the fieldMappings or the expressionToColumns.
if the alias not be used in the order by expr like:
select v1 cc, v2 cc from tbl order by v3
We just add the slotRef(cc) to columnRefOperator in the
expressionToColumns to ensure this projection can output v1 with alias cc, v2 with alias cc and v3.
We don't need to ensure the uniqueness of the alias in the fieldMappings.
if the alias used in the order by expr like:
select v1 v3, v2 cc from (select abs(v1) v1, abs(v2) v2, v3 from t0) t1 order by t1.v3
order by expr t1.v3 referenced the v1 with alias v3, we need set the fieldMappings to ensure order by
expr can be resolved.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: