-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Rewrite repair (backport #50330) #50530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: motto1314 <[email protected]> Signed-off-by: stdpain <[email protected]> Co-authored-by: stdpain <[email protected]> Co-authored-by: trueeyu <[email protected]> (cherry picked from commit 1e10d20) # Conflicts: # be/src/storage/rowset/column_iterator.h # be/src/storage/rowset/scalar_column_iterator.cpp # be/src/storage/rowset/segment_iterator.cpp # be/src/storage/rowset/segment_options.h
Cherry-pick of 1e10d20 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
trueeyu
approved these changes
Sep 2, 2024
24 tasks
trueeyu
pushed a commit
that referenced
this pull request
Sep 5, 2024
Signed-off-by: motto1314 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
#50329 cache data is confusion
What I'm doing:
Rewrite will read the unsubmitted update data, which will be overwritten during submission and should not be cached.
Although 'page_cache=true' was not configured during reading, segment_iterator's 'use_page_cache' did not take effect because scalar_column_iterator.cpp directly referenced 'config::disable_storage_page_cache'.
So add parameter 'temporary_data' to identify temporary data that has not been submitted.
Fixes #50329
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #50330 done by [Mergify](https://mergify.com). ## Why I'm doing: #50329 cache data is confusion
What I'm doing:
Rewrite will read the unsubmitted update data, which will be overwritten during submission and should not be cached.
Although 'page_cache=true' was not configured during reading, segment_iterator's 'use_page_cache' did not take effect because scalar_column_iterator.cpp directly referenced 'config::disable_storage_page_cache'.
So add parameter 'temporary_data' to identify temporary data that has not been submitted.
Fixes #50329
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: