Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix multiple partition column statistics #50488

Merged

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Aug 30, 2024

Why I'm doing:

What I'm doing:

  • For multi-column list partition, any column should be considered as the statistics

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@murphyatwork murphyatwork requested a review from a team as a code owner August 30, 2024 11:22
Copy link

sonarcloud bot commented Sep 2, 2024

Copy link

github-actions bot commented Sep 2, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 2, 2024

[FE Incremental Coverage Report]

pass : 11 / 11 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java 11 11 100.00% []

Copy link

github-actions bot commented Sep 2, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@murphyatwork murphyatwork merged commit 7bdc5bf into StarRocks:main Sep 3, 2024
48 of 49 checks passed
Copy link

github-actions bot commented Sep 3, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

@Mergifyio backport branch-3.2

Copy link

github-actions bot commented Sep 3, 2024

@Mergifyio backport branch-3.1

Copy link
Contributor

mergify bot commented Sep 3, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 3, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 3, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 3, 2024
mergify bot pushed a commit that referenced this pull request Sep 3, 2024
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 7bdc5bf)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
#	test/lib/sr_sql_lib.py
mergify bot pushed a commit that referenced this pull request Sep 3, 2024
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 7bdc5bf)

# Conflicts:
#	test/lib/sr_sql_lib.py
murphyatwork added a commit that referenced this pull request Sep 3, 2024
xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request Sep 6, 2024
va-os-commits pushed a commit to va-os-commits/starrocks that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants