[Enhancement] Support show proc replications #50483

xiangguangyxg · 2024-08-30T09:55:09Z

Why I'm doing:

What I'm doing:

Support show proc replications

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

fe/fe-core/src/main/java/com/starrocks/replication/ReplicationJob.java

fe/fe-core/src/main/java/com/starrocks/replication/ReplicationMgr.java

fe/fe-core/src/main/java/com/starrocks/common/proc/ReplicationsProcNode.java

Signed-off-by: xiangguangyxg <[email protected]>

fe/fe-core/src/main/java/com/starrocks/replication/ReplicationMgr.java

Signed-off-by: xiangguangyxg <[email protected]>

sonarcloud · 2024-09-02T09:37:44Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-09-02T10:57:31Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-09-02T10:58:06Z

[FE Incremental Coverage Report]

✅ pass : 91 / 103 (88.35%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/journal/JournalEntity.java	0	3	00.00%	[1152, 1153, 1154]
🔵	com/starrocks/persist/EditLog.java	3	6	50.00%	[1189, 1190, 1191]
🔵	com/starrocks/replication/ReplicationJob.java	17	22	77.27%	[461, 462, 463, 464, 466]
🔵	com/starrocks/replication/ReplicationMgr.java	40	41	97.56%	[175]
🔵	com/starrocks/common/proc/ReplicationsProcNode.java	30	30	100.00%	[]
🔵	com/starrocks/common/proc/ProcService.java	1	1	100.00%	[]

github-actions · 2024-09-02T10:58:23Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-09-02T11:37:11Z

@Mergifyio backport branch-3.3

github-actions · 2024-09-02T11:37:12Z

@Mergifyio backport branch-3.2

github-actions · 2024-09-02T11:37:14Z

@Mergifyio backport branch-3.1

mergify · 2024-09-02T11:37:25Z

backport branch-3.3

✅ Backports have been created

#50567 [Enhancement] Support show proc replications (backport #50483) has been created for branch branch-3.3 but encountered conflicts

mergify · 2024-09-02T11:37:26Z

backport branch-3.2

✅ Backports have been created

#50568 [Enhancement] Support show proc replications (backport #50483) has been created for branch branch-3.2 but encountered conflicts

mergify · 2024-09-02T11:37:27Z

backport branch-3.1

✅ Backports have been created

#50569 [Enhancement] Support show proc replications (backport #50483) has been created for branch branch-3.1 but encountered conflicts

Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit a88d3e4) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/journal/JournalEntity.java # fe/fe-core/src/main/java/com/starrocks/persist/EditLog.java # fe/fe-core/src/main/java/com/starrocks/replication/ReplicationJob.java

Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit a88d3e4) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/journal/JournalEntity.java # fe/fe-core/src/main/java/com/starrocks/persist/EditLog.java # fe/fe-core/src/main/java/com/starrocks/replication/ReplicationJob.java # fe/fe-core/src/main/java/com/starrocks/replication/ReplicationMgr.java

Signed-off-by: xiangguangyxg <[email protected]> Co-authored-by: xiangguangyxg <[email protected]>

… (StarRocks#50568) Signed-off-by: xiangguangyxg <[email protected]> Co-authored-by: xiangguangyxg <[email protected]>

Support show proc replications Signed-off-by: xiangguangyxg <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Signed-off-by: xiangguangyxg <[email protected]>

Signed-off-by: xiangguangyxg <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

wanpengfei-git added the META-REVIEW label Aug 30, 2024

wanpengfei-git requested a review from a team August 30, 2024 09:55

github-actions bot added the 3.3 label Aug 30, 2024

mergify bot assigned xiangguangyxg Aug 30, 2024

github-actions bot added 3.2 3.1 labels Aug 30, 2024

starrocks-cr bot reviewed Aug 30, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/replication/ReplicationJob.java Outdated Show resolved Hide resolved

starrocks-cr bot reviewed Aug 30, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/replication/ReplicationMgr.java Show resolved Hide resolved

starrocks-cr bot reviewed Aug 30, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/common/proc/ReplicationsProcNode.java Show resolved Hide resolved

xiangguangyxg force-pushed the show_replication branch from 78b670d to bf7f00c Compare August 30, 2024 15:02

[Enhancement] Support show proc replications

88115af

Signed-off-by: xiangguangyxg <[email protected]>

xiangguangyxg force-pushed the show_replication branch from bf7f00c to 88115af Compare September 2, 2024 06:20

gengjun-git reviewed Sep 2, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/replication/ReplicationMgr.java Outdated Show resolved Hide resolved

xiangguangyxg requested a review from a team as a code owner September 2, 2024 08:40

add delete replication job operation

fce4ce5

Signed-off-by: xiangguangyxg <[email protected]>

xiangguangyxg force-pushed the show_replication branch from f885767 to fce4ce5 Compare September 2, 2024 09:28

gengjun-git approved these changes Sep 2, 2024

View reviewed changes

HangyuanLiu approved these changes Sep 2, 2024

View reviewed changes

andyziye merged commit a88d3e4 into StarRocks:main Sep 2, 2024
49 checks passed

github-actions bot removed 3.3 3.2 labels Sep 2, 2024

github-actions bot removed the 3.1 label Sep 2, 2024

mergify bot mentioned this pull request Sep 2, 2024

[Enhancement] Support show proc replications (backport #50483) #50567

Closed

42 tasks

This was referenced Sep 2, 2024

[Enhancement] Support show proc replications (backport #50483) #50568

Merged

[Enhancement] Support show proc replications (backport #50483) #50569

Merged

wanpengfei-git pushed a commit that referenced this pull request Sep 3, 2024

[Enhancement] Support show proc replications (backport #50483) (#50569)

d976483

Signed-off-by: xiangguangyxg <[email protected]> Co-authored-by: xiangguangyxg <[email protected]>

github-actions bot added the 3.1-merged label Sep 3, 2024

wanpengfei-git pushed a commit that referenced this pull request Sep 3, 2024

[Enhancement] Support show proc replications (backport #50483) (#50568)

550f4b8

Signed-off-by: xiangguangyxg <[email protected]> Co-authored-by: xiangguangyxg <[email protected]>

github-actions bot added the 3.2-merged label Sep 3, 2024

xiangguangyxg deleted the show_replication branch September 4, 2024 01:48

xiangguangyxg mentioned this pull request Sep 6, 2024

[Enhancement] Support show proc replications (backport #50483) #50806

Merged

24 tasks

github-actions bot added the 3.3-merged label Sep 6, 2024

va-os-commits pushed a commit to va-os-commits/starrocks that referenced this pull request Sep 10, 2024

[Enhancement] Support show proc replications (StarRocks#50483)

cf62a95

Signed-off-by: xiangguangyxg <[email protected]>

renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024

[Enhancement] Support show proc replications (StarRocks#50483)

2b32d66

Signed-off-by: xiangguangyxg <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Support show proc replications #50483

[Enhancement] Support show proc replications #50483

xiangguangyxg commented Aug 30, 2024

sonarcloud bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

mergify bot commented Sep 2, 2024 •

edited

Loading

mergify bot commented Sep 2, 2024 •

edited

Loading

mergify bot commented Sep 2, 2024 •

edited

Loading

[Enhancement] Support show proc replications #50483

[Enhancement] Support show proc replications #50483

Conversation

xiangguangyxg commented Aug 30, 2024

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarcloud bot commented Sep 2, 2024

Quality Gate passed

github-actions bot commented Sep 2, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Sep 2, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Sep 2, 2024

[BE Incremental Coverage Report]

github-actions bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

mergify bot commented Sep 2, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 2, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 2, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 2, 2024 •

edited

Loading

mergify bot commented Sep 2, 2024 •

edited

Loading

mergify bot commented Sep 2, 2024 •

edited

Loading