Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Decrease get_txn_status_internal_sec to avoid introducing long delay time for stream load task (backport #44060) #50465

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 30, 2024

Why I'm doing:

The default config get_txn_status_internal_sec in be is 30, which means for a stream load task, it might wait more than 30 seconds before it can retrieve the new transaction status.

This might introduce an explicit long delay in the stream load client side.

What I'm doing:

  1. Decrease the default value of get_txn_status_internal_sec from 30 to 10
  2. Add critical warning logs when commit and publish is blocked by the waiting time introduced

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #44060 done by [Mergify](https://mergify.com). ## Why I'm doing:

The default config get_txn_status_internal_sec in be is 30, which means for a stream load task, it might wait more than 30 seconds before it can retrieve the new transaction status.

This might introduce an explicit long delay in the stream load client side.

What I'm doing:

  1. Decrease the default value of get_txn_status_internal_sec from 30 to 10
  2. Add critical warning logs when commit and publish is blocked by the waiting time introduced

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…cing long delay time for stream load task (#44060)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit c2b0370)

# Conflicts:
#	be/src/runtime/stream_load/stream_load_executor.cpp
#	docs/en/administration/management/BE_configuration.md
#	docs/zh/administration/management/BE_configuration.md
@mergify mergify bot added the conflicts label Aug 30, 2024
Copy link
Contributor Author

mergify bot commented Aug 30, 2024

Cherry-pick of c2b0370 has failed:

On branch mergify/bp/branch-2.5/pr-44060
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit c2b0370920.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/common/config.h

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   be/src/runtime/stream_load/stream_load_executor.cpp
	deleted by us:   docs/en/administration/management/BE_configuration.md
	deleted by us:   docs/zh/administration/management/BE_configuration.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Aug 30, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-44060 branch August 30, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge behavior_changed conflicts documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant