Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Reduce the memory useage of TableStatistic (backport #50316) #50373

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 28, 2024

Why I'm doing:

image
image

What I'm doing:

to reduce memory usage
for avoid bugs: will init too much cacheKey when the data of statistics table is error (history bugs, doesn't delete statistics rows when truncate table or drop partitions).

  • update Cache getAll implement: only query exists partitions, not all partition
  • replace TableStatistic by Long, tableID and partitionID is unused

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #50316 done by [Mergify](https://mergify.com). ## Why I'm doing: ![image](https://github.com/user-attachments/assets/e75b9508-936d-491b-8d69-7ca3c376b16e) ![image](https://github.com/user-attachments/assets/6b8be65b-ac0a-43da-b99e-36f6b28092d8)

What I'm doing:

to reduce memory usage
for avoid bugs: will init too much cacheKey when the data of statistics table is error (history bugs, doesn't delete statistics rows when truncate table or drop partitions).

  • update Cache getAll implement: only query exists partitions, not all partition
  • replace TableStatistic by Long, tableID and partitionID is unused

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link
Contributor Author

mergify bot commented Aug 28, 2024

Cherry-pick of 16ca57c has failed:

On branch mergify/bp/branch-3.1/pr-50316
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 16ca57cd0e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/CachedStatisticStorage.java
	deleted:    fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/TableStatistic.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/TableStatsCacheLoader.java
	modified:   fe/fe-core/src/main/java/com/starrocks/statistic/StatisticExecutor.java
	modified:   fe/fe-core/src/main/java/com/starrocks/statistic/StatisticSQLBuilder.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticStorage.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticsCalcUtils.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/statistic/BasicStatsMeta.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/MockTpchStatisticStorage.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Aug 28, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) August 28, 2024 09:44
@mergify mergify bot closed this Aug 28, 2024
auto-merge was automatically disabled August 28, 2024 09:44

Pull request was closed

Copy link
Contributor Author

mergify bot commented Aug 28, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.1/pr-50316 branch August 28, 2024 09:45
@Seaven Seaven restored the mergify/bp/branch-3.1/pr-50316 branch September 2, 2024 08:34
@Seaven Seaven reopened this Sep 2, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 2, 2024 08:35
@Seaven Seaven force-pushed the mergify/bp/branch-3.1/pr-50316 branch 2 times, most recently from 8e570d8 to bc073bb Compare September 2, 2024 09:12
@Seaven Seaven force-pushed the mergify/bp/branch-3.1/pr-50316 branch from bc073bb to 5c77754 Compare September 2, 2024 09:37
Copy link

sonarcloud bot commented Sep 2, 2024

@wanpengfei-git wanpengfei-git merged commit a5b5316 into branch-3.1 Sep 2, 2024
29 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.1/pr-50316 branch September 2, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants