-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Support multi version of group_concat in FE #50074
Open
LiShuMing
wants to merge
2
commits into
StarRocks:main
Choose a base branch
from
LiShuMing:fix/main/support_multi_version_aggs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Refactor] Support multi version of group_concat in FE #50074
LiShuMing
wants to merge
2
commits into
StarRocks:main
from
LiShuMing:fix/main/support_multi_version_aggs
+475
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/ExpressionAnalyzer.java
Show resolved
Hide resolved
LiShuMing
force-pushed
the
fix/main/support_multi_version_aggs
branch
3 times, most recently
from
August 22, 2024 12:24
eff5edd
to
c024359
Compare
LiShuMing
force-pushed
the
fix/main/support_multi_version_aggs
branch
from
September 20, 2024 03:24
c024359
to
22471f6
Compare
LiShuMing
force-pushed
the
fix/main/support_multi_version_aggs
branch
2 times, most recently
from
October 18, 2024 09:27
f3cecc2
to
970caa0
Compare
Signed-off-by: shuming.li <[email protected]>
LiShuMing
changed the title
[Refactor] Support multi version of group_concat
[Refactor] Support multi version of group_concat in FE
Oct 21, 2024
Signed-off-by: shuming.li <[email protected]>
LiShuMing
force-pushed
the
fix/main/support_multi_version_aggs
branch
from
October 21, 2024 10:01
37386c2
to
ce98e0c
Compare
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 71 / 78 (91.03%) file detail
|
[BE Incremental Coverage Report]✅ pass : 22 / 23 (95.65%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Current
group_concat
supportsdistinct
andorder by
arguments forgroup_concat
, so in Be there are two implements:group_concat
andgroup_concat2
. But to support common aggregate aggregate state, I foundgroup_concat
is difficult to support because:parser
to add the defaultseperator
by defaultstruct
to save the intermedaite type which is useful whengroup_concat
containsdistinct
ororder by
arguments but it's a bit redundant if not contains.GROUP_CONCAT_LEGACY
dialect, but it may generate wrong result in some current implementation.What I'm doing:
group_concat
orgroup_concat2
by whether containscontains
distinctor
order by ` arguments142: optional string default_group_concat_separator;
in thrift to use decide the default behavior rather than inparser
.group_concat
in common aggregate state table.To be compatible with old version(3.3), I have tested old FE with the BE(with the PR), and It's ok in this situation.
Fixes #49000
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: