Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Support multi version of group_concat in FE #50074

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Aug 21, 2024

Why I'm doing:

Current group_concat supports distinct and order by arguments for group_concat, so in Be there are two implements: group_concat and group_concat2. But to support common aggregate aggregate state, I found group_concat is difficult to support because:

  1. It's changed in parser to add the default seperator by default
  2. It use struct to save the intermedaite type which is useful when group_concat contains distinct or order by arguments but it's a bit redundant if not contains.
  3. Even though there is GROUP_CONCAT_LEGACY dialect, but it may generate wrong result in some current implementation.

What I'm doing:

  • Support multi version of group_concat in FE as the same with BE which will decide to use group_concat or group_concat2 by whether contains containsdistinctororder by ` arguments
  • Add 142: optional string default_group_concat_separator; in thrift to use decide the default behavior rather than in parser.
  • Support group_concat in common aggregate state table.

To be compatible with old version(3.3), I have tested old FE with the BE(with the PR), and It's ok in this situation.

Fixes #49000

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing LiShuMing force-pushed the fix/main/support_multi_version_aggs branch 3 times, most recently from eff5edd to c024359 Compare August 22, 2024 12:24
@LiShuMing LiShuMing force-pushed the fix/main/support_multi_version_aggs branch from c024359 to 22471f6 Compare September 20, 2024 03:24
@LiShuMing LiShuMing force-pushed the fix/main/support_multi_version_aggs branch 2 times, most recently from f3cecc2 to 970caa0 Compare October 18, 2024 09:27
@LiShuMing LiShuMing changed the title [Refactor] Support multi version of group_concat [Refactor] Support multi version of group_concat in FE Oct 21, 2024
Signed-off-by: shuming.li <[email protected]>
@LiShuMing LiShuMing force-pushed the fix/main/support_multi_version_aggs branch from 37386c2 to ce98e0c Compare October 21, 2024 10:01
Copy link

sonarcloud bot commented Oct 22, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 71 / 78 (91.03%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/analysis/FunctionParams.java 0 2 00.00% [116, 127]
🔵 com/starrocks/sql/optimizer/rule/transformation/RewriteMultiDistinctRule.java 6 8 75.00% [173, 179]
🔵 com/starrocks/sql/analyzer/ExpressionAnalyzer.java 15 18 83.33% [1163, 1174, 1176]
🔵 com/starrocks/sql/optimizer/rule/transformation/SplitTwoPhaseAggRule.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/SplitAggregateRule.java 1 1 100.00% []
🔵 com/starrocks/qe/SessionVariable.java 2 2 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/MultiDistinctByCTERewriter.java 10 10 100.00% []
🔵 com/starrocks/catalog/FunctionSet.java 10 10 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/EliminateAggRule.java 13 13 100.00% []
🔵 com/starrocks/sql/analyzer/AstToStringBuilder.java 9 9 100.00% []
🔵 com/starrocks/sql/optimizer/Utils.java 1 1 100.00% []
🔵 com/starrocks/sql/analyzer/FunctionAnalyzer.java 3 3 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 22 / 23 (95.65%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/aggregator.cpp 8 9 88.89% [570]
🔵 be/src/exprs/agg/group_concat.h 8 8 100.00% []
🔵 be/src/exprs/function_context.h 6 6 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Generic Aggregate Function State
2 participants