Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix explain logical Stackoverflow #49864

Merged
merged 1 commit into from
Sep 21, 2024
Merged

[BugFix] Fix explain logical Stackoverflow #49864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions fe/fe-core/src/main/java/com/starrocks/sql/Explain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,11 @@ List<OperatorStr> buildChildOperatorStr(OptExpression optExpression, int step) {
return childString;
}

@Override
public OperatorStr visitPhysicalProject(OptExpression optExpression, OperatorPrinter.ExplainContext context) {
return visit(optExpression.getInputs().get(0), context);
}

@Override
public OperatorStr visitPhysicalOlapScan(OptExpression optExpression, OperatorPrinter.ExplainContext context) {
PhysicalOlapScanOperator scan = (PhysicalOlapScanOperator) optExpression.getOp();
Expand Down
6 changes: 0 additions & 6 deletions fe/fe-core/src/main/java/com/starrocks/sql/optimizer/Optimizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,6 @@ public OptExpression optimize(ConnectContext connectContext,
// prepare for optimizer
prepare(connectContext, columnRefFactory, logicOperatorTree);

// try text based mv rewrite first before mv rewrite prepare so can deduce mv prepare time if it can be rewritten.
try (Timer ignored = Tracers.watchScope("MVTextRewrite")) {
logicOperatorTree = new TextMatchBasedRewriteRule(connectContext, stmt, mvTransformerContext)
.transform(logicOperatorTree, context).get(0);
}

// prepare for mv rewrite
prepareMvRewrite(connectContext, logicOperatorTree, columnRefFactory, requiredColumns);

Expand Down
Loading