Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix http server direct buffer leak for request body (backport #49395) #49628

Merged
merged 2 commits into from
Aug 9, 2024
Merged

[BugFix] Fix http server direct buffer leak for request body (backport #49395) #49628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b675d91
[BugFix] Fix http server direct buffer leak for request body (#49395)
gengjun-git Aug 9, 2024
0fa2db4
resolve
gengjun-git Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions fe/fe-core/src/main/java/com/starrocks/http/HttpServerHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,11 @@ public void channelReadComplete(ChannelHandlerContext ctx) {

@Override
public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
if (msg instanceof HttpRequest) {
try {
if (!(msg instanceof HttpRequest)) {
return;
}

this.request = (HttpRequest) msg;
if (LOG.isDebugEnabled()) {
LOG.debug("request: url:[{}]", request.uri());
Expand Down Expand Up @@ -91,7 +95,7 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
req.getRequest().uri(), Thread.currentThread().getId(), startTime, latency);
}
}
} else {
} finally {
ReferenceCountUtil.release(msg);
}
}
Expand Down
Loading