[Enhancement] Add big query error in audit log #49611

ZiheLiu · 2024-08-08T12:02:33Z

Why I'm doing:

When exceeding the thredsholds of big_query_cpu_second_limit or big_query_scan_rows_limit, the query will be failed.
However, we don't know a query is killed by which big query thredsholds or other reasons.

What I'm doing:

Add BIG_QUERY_CPU_SECOND_LIMIT_EXCEEDED and BIG_QUERY_SCAN_ROWS_LIMIT_EXCEEDED to TStatusCode.

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[] Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Documentation PRs only:

If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.

Yes, translate English markdown files with GPT
Do not translate

Signed-off-by: zihe.liu <[email protected]>

sonarcloud · 2024-08-09T02:44:55Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dirtysalt · 2024-08-09T04:14:07Z

be/src/common/status.cpp

@@ -261,6 +261,10 @@ std::string Status::code_as_string() const {
        return "Capaticy limit exceeded";
    case TStatusCode::SHUTDOWN:
        return "Shut down in progress";
+    case TStatusCode::BIG_QUERY_CPU_SECOND_LIMIT_EXCEEDED:


do you have to handle big query memory limit?

big_query_mem_limit is also handled by TStatusCode:MEM_LIMIT_EXCEEDED.

dirtysalt · 2024-08-09T04:15:28Z

LGTM

github-actions · 2024-08-09T07:47:21Z

[FE Incremental Coverage Report]

✅ pass : 9 / 9 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/http/HttpConnectProcessor.java	1	1	100.00%	[]
🔵	com/starrocks/qe/ConnectContext.java	6	6	100.00%	[]
🔵	com/starrocks/qe/ConnectProcessor.java	2	2	100.00%	[]

github-actions · 2024-08-09T07:57:14Z

[BE Incremental Coverage Report]

❌ fail : 0 / 12 (00.00%)

file detail

	path	new_line	coverage	not_covered_line_detail
🔵	be/src/exec/workgroup/work_group.cpp	6	00.00%	[237, 238, 239, 248, 249, 250]
🔵	be/src/common/status.h	2	00.00%	[157, 160]
🔵	be/src/common/status.cpp	4	00.00%	[264, 265, 266, 267]

dirtysalt · 2024-08-09T12:12:37Z

@alvin-celerdata do you think it's okay to merge? it's hard to cover resource group code.

gensrc/thrift/StatusCode.thrift

github-actions · 2024-08-09T23:33:13Z

@Mergifyio backport branch-3.3

github-actions · 2024-08-09T23:33:14Z

@Mergifyio backport branch-3.2

Why I'm doing: When exceeding the thredsholds of big_query_cpu_second_limit or big_query_scan_rows_limit, the query will be failed. However, we don't know a query is killed by which big query thredsholds or other reasons. What I'm doing: Add BIG_QUERY_CPU_SECOND_LIMIT_EXCEEDED and BIG_QUERY_SCAN_ROWS_LIMIT_EXCEEDED to TStatusCode. Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit 2e68c7e) # Conflicts: # be/src/common/status.cpp # be/src/common/status.h # gensrc/thrift/StatusCode.thrift

Why I'm doing: When exceeding the thredsholds of big_query_cpu_second_limit or big_query_scan_rows_limit, the query will be failed. However, we don't know a query is killed by which big query thredsholds or other reasons. What I'm doing: Add BIG_QUERY_CPU_SECOND_LIMIT_EXCEEDED and BIG_QUERY_SCAN_ROWS_LIMIT_EXCEEDED to TStatusCode. Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit 2e68c7e) # Conflicts: # be/src/common/status.cpp # be/src/common/status.h # fe/fe-core/src/test/java/com/starrocks/qe/ConnectContextTest.java # gensrc/thrift/StatusCode.thrift

Why I'm doing: When exceeding the thredsholds of big_query_cpu_second_limit or big_query_scan_rows_limit, the query will be failed. However, we don't know a query is killed by which big query thredsholds or other reasons. What I'm doing: Add BIG_QUERY_CPU_SECOND_LIMIT_EXCEEDED and BIG_QUERY_SCAN_ROWS_LIMIT_EXCEEDED to TStatusCode. Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit 2e68c7e) # Conflicts: # be/src/common/status.cpp # fe/fe-core/src/main/java/com/starrocks/http/HttpConnectProcessor.java # fe/fe-core/src/main/java/com/starrocks/qe/ConnectContext.java # fe/fe-core/src/test/java/com/starrocks/qe/ConnectContextTest.java # gensrc/thrift/StatusCode.thrift

Why I'm doing: When exceeding the thredsholds of big_query_cpu_second_limit or big_query_scan_rows_limit, the query will be failed. However, we don't know a query is killed by which big query thredsholds or other reasons. What I'm doing: Add BIG_QUERY_CPU_SECOND_LIMIT_EXCEEDED and BIG_QUERY_SCAN_ROWS_LIMIT_EXCEEDED to TStatusCode. Signed-off-by: zihe.liu <[email protected]>

) Signed-off-by: zihe.liu <[email protected]>

s

ccae1bd

Signed-off-by: zihe.liu <[email protected]>

ZiheLiu requested review from a team as code owners August 8, 2024 12:02

wanpengfei-git added the PROTO-REVIEW label Aug 8, 2024

github-actions bot added the 3.3 label Aug 8, 2024

mergify bot assigned ZiheLiu Aug 8, 2024

github-actions bot added 3.2 3.1 3.0 2.5 labels Aug 8, 2024

wanpengfei-git requested a review from a team August 8, 2024 12:03

satanson previously approved these changes Aug 8, 2024

View reviewed changes

add test

2ff7b74

Signed-off-by: zihe.liu <[email protected]>

ZiheLiu dismissed satanson’s stale review via 2ff7b74 August 9, 2024 02:38

dirtysalt reviewed Aug 9, 2024

View reviewed changes

dirtysalt approved these changes Aug 9, 2024

View reviewed changes

dirtysalt enabled auto-merge (squash) August 9, 2024 12:12

alvin-celerdata reviewed Aug 9, 2024

View reviewed changes

gensrc/thrift/StatusCode.thrift Show resolved Hide resolved

alvin-celerdata approved these changes Aug 9, 2024

View reviewed changes

alvin-celerdata disabled auto-merge August 9, 2024 23:32

alvin-celerdata merged commit 2e68c7e into StarRocks:main Aug 9, 2024
62 of 66 checks passed

github-actions bot removed the 3.3 label Aug 9, 2024

mergify bot mentioned this pull request Aug 9, 2024

[Enhancement] Add big query error in audit log (backport #49611) #49675

Closed

42 tasks

This was referenced Aug 9, 2024

[Enhancement] Add big query error in audit log (backport #49611) #49676

Closed

[Enhancement] Add big query error in audit log (backport #49611) #49677

Closed

This was referenced Aug 9, 2024

[Enhancement] Add big query error in audit log (backport #49611) #49678

Closed

[Enhancement] Add big query error in audit log (backport #49611) #49679

Closed

This was referenced Aug 14, 2024

[Enhancement] Add big query error in audit log (backport #49611) #49778

Merged

[Enhancement] Add big query error in audit log (backport #49611) #49779

Merged

ZiheLiu mentioned this pull request Aug 14, 2024

[Enhancement] Add big query error in audit log (backport #49611) #49780

Merged

26 tasks

ZiheLiu mentioned this pull request Aug 14, 2024

[Enhancement] Add big query error in audit log (backport #49611) #49781

Merged

26 tasks

ZiheLiu mentioned this pull request Aug 14, 2024

[Enhancement] Add big query error in audit log (backport #49611) #49782

Merged

26 tasks

kangkaisen pushed a commit that referenced this pull request Aug 14, 2024

[Enhancement] Add big query error in audit log (backport #49611) (#49778

34c5b25

) Signed-off-by: zihe.liu <[email protected]>

github-actions bot added the 3.2-merged label Aug 14, 2024

kangkaisen pushed a commit that referenced this pull request Aug 14, 2024

[Enhancement] Add big query error in audit log (backport #49611) (#49780

b3c48f9

) Signed-off-by: zihe.liu <[email protected]>

kangkaisen pushed a commit that referenced this pull request Aug 14, 2024

[Enhancement] Add big query error in audit log (backport #49611) (#49781

0bfaa8a

) Signed-off-by: zihe.liu <[email protected]>

github-actions bot added 3.1-merged 3.0-merged labels Aug 14, 2024

kangkaisen pushed a commit that referenced this pull request Aug 14, 2024

[Enhancement] Add big query error in audit log (backport #49611) (#49782

16898c5

) Signed-off-by: zihe.liu <[email protected]>

github-actions bot added the 2.5-merged label Aug 14, 2024

ZiheLiu added a commit that referenced this pull request Aug 14, 2024

[Enhancement] Add big query error in audit log (backport #49611) (#49779

79d4c86

) Signed-off-by: zihe.liu <[email protected]>

github-actions bot added the 3.3-merged label Aug 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Add big query error in audit log #49611

[Enhancement] Add big query error in audit log #49611

ZiheLiu commented Aug 8, 2024 •

edited

Loading

sonarcloud bot commented Aug 9, 2024

dirtysalt Aug 9, 2024

ZiheLiu Aug 9, 2024

dirtysalt commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

dirtysalt commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

[Enhancement] Add big query error in audit log #49611

[Enhancement] Add big query error in audit log #49611

Conversation

ZiheLiu commented Aug 8, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Documentation PRs only:

sonarcloud bot commented Aug 9, 2024

Quality Gate passed

dirtysalt Aug 9, 2024

Choose a reason for hiding this comment

ZiheLiu Aug 9, 2024

Choose a reason for hiding this comment

dirtysalt commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Aug 9, 2024

[BE Incremental Coverage Report]

file detail

dirtysalt commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

ZiheLiu commented Aug 8, 2024 •

edited

Loading