-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Capture query context when use its mem_tracker out of its lifetime #49123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satanson
changed the title
[BugFix] Capture query context when use its mem_tacker out of its lifetime
[BugFix] Capture query context when use its mem_tracker out of its lifetime
Jul 30, 2024
satanson
force-pushed
the
capture_query_context
branch
from
July 30, 2024 06:22
035a675
to
66e10bc
Compare
…fetime Signed-off-by: satanson <[email protected]>
satanson
force-pushed
the
capture_query_context
branch
from
July 30, 2024 07:06
66e10bc
to
24bba05
Compare
ZiheLiu
approved these changes
Jul 30, 2024
silverbullet233
approved these changes
Jul 30, 2024
stdpain
approved these changes
Jul 30, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 6 / 7 (85.71%) file detail
|
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
…fetime (#49123) Signed-off-by: satanson <[email protected]> (cherry picked from commit e2c37db)
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
…fetime (#49123) Signed-off-by: satanson <[email protected]> (cherry picked from commit e2c37db)
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
…fetime (#49123) Signed-off-by: satanson <[email protected]> (cherry picked from commit e2c37db)
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
…fetime (#49123) Signed-off-by: satanson <[email protected]> (cherry picked from commit e2c37db) # Conflicts: # be/src/runtime/runtime_filter_worker.cpp
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
…fetime (#49123) Signed-off-by: satanson <[email protected]> (cherry picked from commit e2c37db) # Conflicts: # be/src/runtime/runtime_filter_worker.cpp
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 31, 2024
…fetime (backport #49123) (#49162) Co-authored-by: satanson <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 31, 2024
…fetime (backport #49123) (#49163) Co-authored-by: satanson <[email protected]>
satanson
added a commit
that referenced
this pull request
Jul 31, 2024
…fetime (backport #49123) Signed-off-by: satanson <[email protected]>
satanson
added a commit
that referenced
this pull request
Jul 31, 2024
…fetime (backport #49123) Signed-off-by: satanson <[email protected]>
ignore backport check: 2.5.19 |
ignore backport check: 3.3.2 |
andyziye
pushed a commit
that referenced
this pull request
Jul 31, 2024
…fetime (backport #49123) (#49196) Signed-off-by: satanson <[email protected]>
andyziye
pushed a commit
that referenced
this pull request
Jul 31, 2024
…fetime (backport #49123) (#49202) Signed-off-by: satanson <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 8, 2024
…fetime (backport #49123) (#49161) Co-authored-by: satanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing
RuntimeFilterWorker may handle a delay runtime filter of a pre-maturely terminating query, so a query context is destructed before the using its query-level mem_tacker in RuntimeFilterWorker. when this mem_tracker is undergoing
desctruction, its parent mem_tracker (e.g. resource_group-level mem_tracker) would be accessed, however, the resource-group-level mem trackers has already been destructed when the resource group is dropped or altered.
Using query-level mem-tracker beyond query context's life time may lead to BE's crash as follows:
What I'm doing:
We need capture query context to prevent it from being destructed, and when a dropping resource_group is used by outstanding query contexts, it would be delayed to be dropped until all its outstanding query contexts are destructed.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: