Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix exp returns incorrect value (backport #47842) #48019

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 9, 2024

Why I'm doing:

exp func returns NULL when input greater than 6
image

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #47842 done by [Mergify](https://mergify.com). ## Why I'm doing: exp func returns NULL when input greater than 6 image

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

@mergify mergify bot added the conflicts label Jul 9, 2024
Copy link
Contributor Author

mergify bot commented Jul 9, 2024

Cherry-pick of e89d2e6 has failed:

On branch mergify/bp/branch-2.5/pr-47842
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit e89d2e61fa.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/test/exprs/vectorized/math_functions_test.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/exprs/vectorized/math_functions.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Jul 9, 2024
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) July 9, 2024 06:24
@mergify mergify bot closed this Jul 9, 2024
Copy link
Contributor Author

mergify bot commented Jul 9, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

auto-merge was automatically disabled July 9, 2024 06:24

Pull request was closed

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-47842 branch July 9, 2024 06:25
@Seaven Seaven restored the mergify/bp/branch-2.5/pr-47842 branch July 10, 2024 02:37
@Seaven Seaven reopened this Jul 10, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) July 10, 2024 02:38
@Seaven Seaven force-pushed the mergify/bp/branch-2.5/pr-47842 branch from bdcd80a to d9377d6 Compare July 10, 2024 02:39
Seaven
Seaven previously approved these changes Jul 11, 2024
Signed-off-by: Yi Wang <[email protected]>
(cherry picked from commit e89d2e6)

Signed-off-by: Yi <[email protected]>
@wanpengfei-git wanpengfei-git merged commit 9fc7dd7 into branch-2.5 Jul 11, 2024
27 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-2.5/pr-47842 branch July 11, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants