-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Add [[nodiscard]] to functions #30935
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satanson <[email protected]>
stdpain
previously approved these changes
Sep 13, 2023
fixed #27471 |
silverbullet233
previously approved these changes
Sep 13, 2023
satanson
force-pushed
the
fixup_nodiscard_status
branch
from
September 13, 2023 05:07
829405d
to
468aece
Compare
satanson
force-pushed
the
fixup_nodiscard_status
branch
3 times, most recently
from
September 13, 2023 13:51
8940bd7
to
4a4a938
Compare
Signed-off-by: satanson <[email protected]>
satanson
force-pushed
the
fixup_nodiscard_status
branch
from
September 13, 2023 16:14
4a4a938
to
ba3b87b
Compare
[FE Incremental Coverage Report]😍 pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]😞 fail : 3 / 37 (08.11%) file detail
|
silverbullet233
approved these changes
Sep 14, 2023
kangkaisen
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: