Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add [[nodiscard]] to functions #30935

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

satanson
Copy link
Contributor

@satanson satanson commented Sep 13, 2023

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • [] Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

stdpain
stdpain previously approved these changes Sep 13, 2023
@silverbullet233
Copy link
Contributor

fixed #27471

Signed-off-by: satanson <[email protected]>
@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 3 / 37 (08.11%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/hash_joiner.cpp 0 4 00.00% [245, 247, 340, 549]
🔵 src/exec/pipeline/hashjoin/spillable_hash_join_probe_operator.cpp 0 2 00.00% [228, 338]
🔵 src/exec/hash_join_components.cpp 0 4 00.00% [22, 26, 27, 82]
🔵 src/exec/hash_join_node.cpp 0 2 00.00% [561, 892]
🔵 src/exec/hash_joiner.h 0 9 00.00% [263, 265, 266, 269, 271, 272, 280, 297, 314]
🔵 src/exec/query_cache/cache_operator.cpp 0 2 00.00% [525, 527]
🔵 src/exec/pipeline/hashjoin/hash_join_probe_operator.cpp 0 2 00.00% [78, 122]
🔵 src/exec/join_hash_map.cpp 0 1 00.00% [461]
🔵 src/exec/pipeline/runtime_filter_types.h 1 9 11.11% [223, 224, 229, 252, 310, 389, 397, 398]
🔵 src/exec/query_cache/cache_manager.cpp 2 2 100.00% []

@kangkaisen kangkaisen merged commit aeaf9fb into StarRocks:main Sep 14, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants