-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Do not do filter pushdown for project that contains lambda function #52655
Merged
wanpengfei-git
merged 9 commits into
StarRocks:main
from
hagonzal:hagonzal_push_down_fix
Nov 11, 2024
Merged
[Enhancement] Do not do filter pushdown for project that contains lambda function #52655
wanpengfei-git
merged 9 commits into
StarRocks:main
from
hagonzal:hagonzal_push_down_fix
Nov 11, 2024
+99
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoyli
changed the title
Do not do filter pushdown for project that contains lambda function
[Enhancement] Do not do filter pushdown for project that contains lambda function
Nov 6, 2024
Seaven
previously approved these changes
Nov 7, 2024
silverbullet233
previously approved these changes
Nov 7, 2024
LGTM, but the code coverage check of FE does not pass, you need to add some test cases in |
chaoyli
reviewed
Nov 8, 2024
Added unit tests. |
Quality Gate passedIssues Measures |
chaoyli
approved these changes
Nov 8, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 18 / 19 (94.74%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
silverbullet233
approved these changes
Nov 9, 2024
stdpain
approved these changes
Nov 11, 2024
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 11, 2024
…bda function (backport #52655) (#52781) Co-authored-by: Hector Gonzalez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
prevent expensive array_map from being pushed down.
What I'm doing:
Optionally disable predicate pushdown for lambda expressions through the new set variable:
set disable_lambda_pushdown=true
Example:
explain:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: