-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] avoid hudi context npe when cache reload in background #50987
Merged
dirtysalt
merged 3 commits into
StarRocks:main
from
dirtysalt:fix-hudi-context-npe-refresh
Sep 19, 2024
Merged
[BugFix] avoid hudi context npe when cache reload in background #50987
dirtysalt
merged 3 commits into
StarRocks:main
from
dirtysalt:fix-hudi-context-npe-refresh
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-shelby
previously approved these changes
Sep 12, 2024
dirtysalt
force-pushed
the
fix-hudi-context-npe-refresh
branch
from
September 12, 2024 06:12
f0e29b0
to
b930694
Compare
Youngwb
previously approved these changes
Sep 12, 2024
dirtysalt
dismissed stale reviews from Youngwb and stephen-shelby
via
September 12, 2024 07:17
5a33bdc
dirtysalt
changed the title
[Bugfix] avoid hudi context npe when cache reload in background
[BugFix] avoid hudi context npe when cache reload in background
Sep 12, 2024
dirtysalt
force-pushed
the
fix-hudi-context-npe-refresh
branch
from
September 18, 2024 06:06
5a33bdc
to
4ca926f
Compare
-e Signed-off-by: yanz <[email protected]>
Signed-off-by: yanz <[email protected]>
dirtysalt
force-pushed
the
fix-hudi-context-npe-refresh
branch
from
September 18, 2024 23:54
4ca926f
to
0fee632
Compare
Signed-off-by: yanz <[email protected]>
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 13 / 16 (81.25%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
stephen-shelby
approved these changes
Sep 19, 2024
Youngwb
approved these changes
Sep 19, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: yanz <[email protected]> (cherry picked from commit 7e9eb06) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/connector/RemoteFileScanContext.java # fe/fe-core/src/main/java/com/starrocks/connector/RemotePathKey.java # fe/fe-core/src/main/java/com/starrocks/connector/hudi/HudiRemoteFileIO.java # fe/fe-core/src/test/java/com/starrocks/connector/RemoteFileOperationsTest.java
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: yanz <[email protected]> (cherry picked from commit 7e9eb06) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/connector/RemoteFileScanContext.java # fe/fe-core/src/main/java/com/starrocks/connector/RemotePathKey.java # fe/fe-core/src/main/java/com/starrocks/connector/hudi/HudiRemoteFileIO.java # fe/fe-core/src/test/java/com/starrocks/connector/RemoteFileOperationsTest.java
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 19, 2024
…port #50987) (#51146) Signed-off-by: yanz <[email protected]> Co-authored-by: yanz <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 19, 2024
…port #50987) (#51145) Signed-off-by: yanz <[email protected]> Co-authored-by: yanz <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…Rocks#50987) Signed-off-by: yanz <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
I see a lot of warning in fe.out
It's because when cache reload in background,
RemotePathKey
does not have scan context object, which leads to NPE.but in most cases, scan context has been set before listing files.
What I'm doing:
Create scan context when it's nullptr.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: