Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] avoid hudi context npe when cache reload in background #50987

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

dirtysalt
Copy link
Contributor

@dirtysalt dirtysalt commented Sep 12, 2024

Why I'm doing:

I see a lot of warning in fe.out

Sep 11, 2024 7:12:30 PM com.google.common.cache.LocalCache$Segment lambda$loadAsync$0
WARNING: Exception thrown during refresh
java.util.concurrent.ExecutionException: java.lang.NullPointerException
        at com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:592)
        at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:551)
        at com.google.common.util.concurrent.FluentFuture$TrustedFuture.get(FluentFuture.java:91)
        at com.google.common.util.concurrent.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:247)
        at com.google.common.cache.LocalCache$Segment.getAndRecordStats(LocalCache.java:2345)
        at com.google.common.cache.LocalCache$Segment.lambda$loadAsync$0(LocalCache.java:2325)
        at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
        at com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1286)
        at com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:1055)
        at com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:807)
        at com.google.common.util.concurrent.AbstractTransformFuture.run(AbstractTransformFuture.java:105)
        at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
        at com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:145)
        at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)
        at com.google.common.util.concurrent.ListenableFutureTask.done(ListenableFutureTask.java:113)
        at java.base/java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:381)
        at java.base/java.util.concurrent.FutureTask.setException(FutureTask.java:250)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:269)
        at com.starrocks.connector.ReentrantExecutor.lambda$execute$1(ReentrantExecutor.java:46)
        at com.starrocks.connector.BoundedExecutor.releaseQueue(BoundedExecutor.java:77)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.NullPointerException
        at com.starrocks.connector.hudi.HudiRemoteFileIO.createHudiContext(HudiRemoteFileIO.java:61)
        at com.starrocks.connector.hudi.HudiRemoteFileIO.getRemoteFiles(HudiRemoteFileIO.java:99)
        at com.starrocks.connector.CachingRemoteFileIO.loadRemoteFiles(CachingRemoteFileIO.java:93)
        at com.starrocks.connector.CachingRemoteFileIO$1.load(CachingRemoteFileIO.java:54)
        at com.starrocks.connector.CachingRemoteFileIO$1.load(CachingRemoteFileIO.java:51)
        at com.google.common.cache.CacheLoader.reload(CacheLoader.java:100)
        at com.google.common.cache.CacheLoader$1.lambda$reload$0(CacheLoader.java:198)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        ... 5 more

It's because when cache reload in background, RemotePathKey does not have scan context object, which leads to NPE.

but in most cases, scan context has been set before listing files.

What I'm doing:

Create scan context when it's nullptr.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

stephen-shelby
stephen-shelby previously approved these changes Sep 12, 2024
Youngwb
Youngwb previously approved these changes Sep 12, 2024
@dirtysalt dirtysalt changed the title [Bugfix] avoid hudi context npe when cache reload in background [BugFix] avoid hudi context npe when cache reload in background Sep 12, 2024
@dirtysalt dirtysalt enabled auto-merge (squash) September 18, 2024 00:05
Signed-off-by: yanz <[email protected]>
Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 13 / 16 (81.25%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/hudi/HudiRemoteFileIO.java 4 7 57.14% [74, 91, 97]
🔵 com/starrocks/connector/RemoteFileScanContext.java 5 5 100.00% []
🔵 com/starrocks/connector/RemotePathKey.java 4 4 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@dirtysalt dirtysalt merged commit 7e9eb06 into StarRocks:main Sep 19, 2024
46 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 19, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 19, 2024
Copy link
Contributor

mergify bot commented Sep 19, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 19, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 19, 2024
Signed-off-by: yanz <[email protected]>
(cherry picked from commit 7e9eb06)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/RemoteFileScanContext.java
#	fe/fe-core/src/main/java/com/starrocks/connector/RemotePathKey.java
#	fe/fe-core/src/main/java/com/starrocks/connector/hudi/HudiRemoteFileIO.java
#	fe/fe-core/src/test/java/com/starrocks/connector/RemoteFileOperationsTest.java
mergify bot pushed a commit that referenced this pull request Sep 19, 2024
Signed-off-by: yanz <[email protected]>
(cherry picked from commit 7e9eb06)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/RemoteFileScanContext.java
#	fe/fe-core/src/main/java/com/starrocks/connector/RemotePathKey.java
#	fe/fe-core/src/main/java/com/starrocks/connector/hudi/HudiRemoteFileIO.java
#	fe/fe-core/src/test/java/com/starrocks/connector/RemoteFileOperationsTest.java
wanpengfei-git pushed a commit that referenced this pull request Sep 19, 2024
wanpengfei-git pushed a commit that referenced this pull request Sep 19, 2024
@dirtysalt dirtysalt deleted the fix-hudi-context-npe-refresh branch September 19, 2024 12:03
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants