[BugFix] Fix "Connection pool shut down" in S3AFileSystem #50816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smith-Cruise
changed the title
Smith-Cruise
changed the title
Smith-Cruise
changed the title
Smith-Cruise
force-pushed
the
fix-aws
branch
2 times, most recently
from
ba7456e
to
a7c0347
Compare
Smith-Cruise
force-pushed
the
fix-aws
branch
2 times, most recently
from
36bc166
to
afafc20
Compare
kevincai
reviewed
Sep 23, 2024
fe/fe-core/src/main/java/com/starrocks/credential/provider/AWSDefaultCredentialsProvider.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/credential/provider/AWSDefaultCredentialsProvider.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/test/java/com/starrocks/credential/AWSCloudConfigurationTest.java
Outdated
Show resolved
Hide resolved
kevincai
previously approved these changes
Sep 23, 2024
kevincai
reviewed
Sep 23, 2024
fe/fe-core/src/test/java/com/starrocks/credential/AWSCloudConfigurationTest.java
Show resolved
Hide resolved
kevincai
approved these changes
Sep 23, 2024
Smith-Cruise
force-pushed
the
fix-aws
branch
2 times, most recently
from
7ccd16a
to
da7482f
Compare
kevincai
approved these changes
Sep 24, 2024
Signed-off-by: Smith Cruise <[email protected]>
Signed-off-by: Smith Cruise <[email protected]>
Signed-off-by: Smith Cruise <[email protected]>
Signed-off-by: Smith Cruise <[email protected]>
Signed-off-by: Smith Cruise <[email protected]>
Signed-off-by: Smith Cruise <[email protected]>
Signed-off-by: Smith Cruise <[email protected]>
Signed-off-by: Smith Cruise <[email protected]>
Smith-Cruise
force-pushed
the
fix-aws
branch
from
da7482f
to
4b631f8
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 222 / 267 (83.15%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
dirtysalt
approved these changes
Sep 24, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Smith Cruise <[email protected]> (cherry picked from commit 9222444)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Smith Cruise <[email protected]> (cherry picked from commit 9222444) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/credential/aws/AwsCloudConfigurationProvider.java # fe/fe-core/src/test/java/com/starrocks/credential/CloudConfigurationFactoryTest.java # fe/fe-core/src/test/java/com/starrocks/server/SharedDataStorageVolumeMgrTest.java
42 tasks
24 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 24, 2024
…50816) (#51320) Co-authored-by: Smith Cruise <[email protected]>
dirtysalt
pushed a commit
that referenced
this pull request
Sep 24, 2024
…S3AFileSystem (backport #50816) (#51336) Signed-off-by: Smith Cruise <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…50816) Signed-off-by: Smith Cruise <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Fix the below error when using S3AFileSystem +
aws.s3.use_aws_sdk_default_behavior=true.What I'm doing:
We have to implement DefaultCredentialsProvider by ourselves, otherwise we may face "java.lang.IllegalStateException: Connection pool shut down" error.
Hadoop S3AFileSystem will call
static AwsCredentialsProvider::create()to create CredentialsProvider.But in DefaultCredentialsProvider::create(), it will only return a global static variable.
If we close S3AFileSystem, it will also close CredentialsProvider.
For the next time we create a new S3AFileSystem, it will reuse previous closed CredentialsProvider, then error will be thrown.
You can check the details in link: https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/troubleshooting.html#faq-connection-pool-shutdown-exception
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: