Skip to content

Commit

Permalink
[Enhancement] Log only finish operator non-cancel error by cancelling…
Browse files Browse the repository at this point in the history
… (backport #50454) (#50549)

Signed-off-by: zihe.liu <[email protected]>
  • Loading branch information
ZiheLiu authored Sep 2, 2024
1 parent 6e00623 commit aa51a73
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions be/src/exec/pipeline/pipeline_driver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -695,10 +695,11 @@ Status PipelineDriver::_mark_operator_finished(OperatorPtr& op, RuntimeState* st

Status PipelineDriver::_mark_operator_cancelled(OperatorPtr& op, RuntimeState* state) {
Status res = _mark_operator_finished(op, state);
if (!res.ok()) {
LOG(WARNING) << fmt::format("fragment_id {} driver {} cancels operator {} with finished error {}",
print_id(state->fragment_instance_id()), to_readable_string(), op->get_name(),
res.get_error_msg());
if (!res.ok() && !res.is_cancelled()) {
LOG(WARNING) << fmt::format(
"[Driver] failed to finish operator called by cancelling operator [fragment_id={}] [driver={}] "
"[operator={}] [error={}]",
print_id(state->fragment_instance_id()), to_readable_string(), op->get_name(), res.get_error_msg());
}
auto& op_state = _operator_stages[op->get_id()];
if (op_state >= OperatorStage::CANCELLED) {
Expand Down

0 comments on commit aa51a73

Please sign in to comment.