[BugFix] Fix http server direct buffer leak for request body (backport …

…#49395) (#49628) Signed-off-by: gengjun-git <[email protected]> Co-authored-by: gengjun-git <[email protected]>
StarRocks · Aug 9, 2024 · 6d1e2a5 · 6d1e2a5
1 parent 0207e3c
commit 6d1e2a5
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/fe/fe-core/src/main/java/com/starrocks/http/HttpServerHandler.java b/fe/fe-core/src/main/java/com/starrocks/http/HttpServerHandler.java
@@ -59,7 +59,11 @@ public void channelReadComplete(ChannelHandlerContext ctx) {
 
     @Override
     public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
-        if (msg instanceof HttpRequest) {
+        try {
+            if (!(msg instanceof HttpRequest)) {
+                return;
+            }
+
             this.request = (HttpRequest) msg;
             if (LOG.isDebugEnabled()) {
                 LOG.debug("request: url:[{}]", request.uri());
@@ -91,7 +95,7 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
                             req.getRequest().uri(), Thread.currentThread().getId(), startTime, latency);
                 }
             }
-        } else {
+        } finally {
             ReferenceCountUtil.release(msg);
         }
     }