Skip to content

Commit

Permalink
Ace3 port (#87)
Browse files Browse the repository at this point in the history
* Add Ace3 libs

* Buggy, but initial functionality is present

Stubbed in the rough outline for our graphical options. The settings still need to be fixed to work between clients, and only 1 panel is done so far. This is most a proof of concept.

* Create chat panel

* Add combat panel, add headers under the main descriptions

* Create Nameplates panel

* Add Floating Combat Text panel

* Create cVar Panel

* Add getCustomVar and setCustomVar back, not sure what they do

* Adjust margins in cVar browser to match Ace3 styles

* add horizontal separator after general panel desc to match other panels

* Remove libs from repo and pull them in via pkgmeta instead

* Update CI scripts

* Don't scan libs folder in CI

* Update .editorconfig

* Delete unused tempfix file

* Add Status Text panel, fix FCT panel deprecated functionality

Add in a Status Text panel, however a few of the frames have been deprecated in wow Retail. I have hidden the affected options from the GUI for Retail. Likewise, I fixed the lost functionality in FCT earlier in the porting process.

* no need for FCT_SetValue() to be on the addon namespace, make it local

* No need for setStatusTextBars or setStatusText to be on the addon namespace

* Return original reverse-loot and reverse-cleanup functionality

* hack for SetInsertItemsRightToLeft() not being instant

SetInsertItemsLeftToRight() and SetSortBagsRightToLeft() don't happen instantly, thus the UI will retain the old value since the refresh happens too clickly for the "Get" counterparts to reflect the new values. This is a hack wherein we set a 1/2 second timer to refresh the GUI to allow time for the setting to go through.

* Use hidden instead of disabled for client-specific options

* fix CI

* rename CVar browser section

---------

Co-authored-by: Benjamin Staneck <[email protected]>
  • Loading branch information
brittyazel and Stanzilla authored Jul 26, 2024
1 parent c90c107 commit 51d75f9
Show file tree
Hide file tree
Showing 19 changed files with 21,188 additions and 20,721 deletions.
21 changes: 12 additions & 9 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
root = true

[*]
indent_style = space
indent_size = 4
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
root = true

[*]
indent_style = space
indent_size = 4
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.yml]
indent_size = 2
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4
with:
fetch-depth: 150
fetch-depth: 0

- name: Install and run Luacheck
uses: nebularg/actions-luacheck@v1
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4
with:
fetch-depth: 150
fetch-depth: 0

- name: Install and run Luacheck
uses: nebularg/actions-luacheck@v1
Expand Down Expand Up @@ -37,11 +37,6 @@ jobs:
name: AIO-PR${{ github.event.number }}-classic
path: .release/

- uses: actions/upload-artifact@v2
with:
name: AIO-PR${{ github.event.number }}-bcc
path: .release/

- name: Create Cata Package
uses: BigWigsMods/packager@master
with:
Expand All @@ -51,4 +46,3 @@ jobs:
with:
name: AIO-PR${{ github.event.number }}-cata
path: .release/

5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
cvars2.dump
debug.lua
debug.lua
.vscode/
.idea/
libs/
Loading

0 comments on commit 51d75f9

Please sign in to comment.