reviewdog [detekt] report
reported by reviewdog 🐶
Findings (74)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|104 col 18| The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|120 col 18| The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|114 col 60| Error is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|104 col 18| The caught exception is swallowed. The original exception could be lost.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|37 col 1| Needless blank line(s)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|28 col 33| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|73 col 33| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|98 col 19| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|119 col 17| Missing { ... }
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|17 col 1| Unexpected indentation (4) (should be 0)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|40 col 1| Unexpected indentation (12) (should be 8)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|29 col 8| Unnecessary "Unit" return type
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|1 col 1| File must end with a newline (\n)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|4 col 1| Unused import
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|23 col 34| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|70 col 34| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|126 col 2| The file /github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt is not ending with a new line.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|88 col 1| Line detected, which is longer than the defined maximum line length in the code style.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|4 col 1| The import 'androidx.security.crypto.EncryptedFile' is unused.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|23 col 41| Private function store
is unused.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt|70 col 41| Private function read
is unused.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt|1 col 1| File must end with a newline (\n)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt|3 col 31| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt|4 col 38| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt|7 col 43| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt|10 col 38| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt|13 col 2| The file /github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt is not ending with a new line.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt|5 col 21| Private function readResolve
is unused.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt|8 col 21| Private function readResolve
is unused.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt|11 col 21| Private function readResolve
is unused.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|1 col 1| File must end with a newline (\n)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|9 col 47| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|15 col 40| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|19 col 42| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|24 col 47| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|50 col 17| Missing { ... }
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|10 col 6| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|16 col 6| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|20 col 6| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|25 col 6| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|35 col 9| Function keys has 4 return statements which exceeds the limit of 3.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt|58 col 2| The file /github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageSetting.kt is not ending with a new line.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageError.kt|3 col 32| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageError.kt|4 col 25| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageError.kt|8 col 54| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageError.kt|9 col 35| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageError.kt|1 col 1| File must end with a newline (\n)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageError.kt|13 col 2| The file /github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageError.kt is not ending with a new line.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageError.kt|5 col 21| Private function readResolve
is unused.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageError.kt|10 col 21| Private function readResolve
is unused.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/Credentials.kt|5 col 25| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/Credentials.kt|1 col 1| File must end with a newline (\n)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/Credentials.kt|6 col 2| The file /github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/Credentials.kt is not ending with a new line.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorage.kt|1 col 1| File must end with a newline (\n)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorage.kt|12 col 76| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorage.kt|37 col 41| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorage.kt|46 col 36| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorage.kt|54 col 36| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorage.kt|66 col 71| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorage.kt|75 col 36| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorage.kt|83 col 36| Missing trailing comma before ")"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorage.kt|88 col 2| The file /github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorage.kt is not ending with a new line.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageScope.kt|6 col 64| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageScope.kt|7 col 92| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageScope.kt|8 col 71| Missing spacing before ":"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageScope.kt|3 col 1| Unused import
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageScope.kt|1 col 1| File must end with a newline (\n)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageScope.kt|41 col 2| The file /github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageScope.kt is not ending with a new line.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageScope.kt|3 col 1| The import 'android.provider.Settings.Secure' is unused.
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageItemTypes.kt|6 col 27| Missing trailing comma before "}"
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageItemTypes.kt|1 col 1| File must end with a newline (\n)
modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageItemTypes.kt|36 col 2| The file /github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/secure/SecureStorageItemTypes.kt is not ending with a new line.
modules/storage/src/androidTest/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageTests.kt|1 col 1| File must end with a newline (\n)
modules/storage/src/androidTest/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageTests.kt|26 col 2| The file /github/workspace/modules/storage/src/androidTest/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageTests.kt is not ending with a new line.
Filtered Findings (0)
Annotations
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L104 <detekt.TooGenericExceptionCaught>
The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:104:18: warning: The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled. (detekt.TooGenericExceptionCaught)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L120 <detekt.TooGenericExceptionCaught>
The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:120:18: warning: The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled. (detekt.TooGenericExceptionCaught)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L114 <detekt.TooGenericExceptionThrown>
Error is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:114:60: warning: Error is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case. (detekt.TooGenericExceptionThrown)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L104 <detekt.SwallowedException>
The caught exception is swallowed. The original exception could be lost.
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:104:18: warning: The caught exception is swallowed. The original exception could be lost. (detekt.SwallowedException)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L37 <detekt.NoConsecutiveBlankLines>
Needless blank line(s)
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:37:1: warning: Needless blank line(s) (detekt.NoConsecutiveBlankLines)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L28 <detekt.TrailingCommaOnDeclarationSite>
Missing trailing comma before ")"
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:28:33: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L73 <detekt.TrailingCommaOnDeclarationSite>
Missing trailing comma before ")"
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:73:33: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L98 <detekt.TrailingCommaOnDeclarationSite>
Missing trailing comma before ")"
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:98:19: warning: Missing trailing comma before ")" (detekt.TrailingCommaOnDeclarationSite)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L119 <detekt.MultiLineIfElse>
Missing { ... }
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:119:17: warning: Missing { ... } (detekt.MultiLineIfElse)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L17 <detekt.Indentation>
Unexpected indentation (4) (should be 0)
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:17:1: warning: Unexpected indentation (4) (should be 0) (detekt.Indentation)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L40 <detekt.Indentation>
Unexpected indentation (12) (should be 8)
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:40:1: warning: Unexpected indentation (12) (should be 8) (detekt.Indentation)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L29 <detekt.NoUnitReturn>
Unnecessary "Unit" return type
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:29:8: warning: Unnecessary "Unit" return type (detekt.NoUnitReturn)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L1 <detekt.FinalNewline>
File must end with a newline (\n)
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:1:1: warning: File must end with a newline (\n) (detekt.FinalNewline)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L4 <detekt.NoUnusedImports>
Unused import
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:4:1: warning: Unused import (detekt.NoUnusedImports)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L23 <detekt.SpacingAroundColon>
Missing spacing before ":"
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:23:34: warning: Missing spacing before ":" (detekt.SpacingAroundColon)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L70 <detekt.SpacingAroundColon>
Missing spacing before ":"
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:70:34: warning: Missing spacing before ":" (detekt.SpacingAroundColon)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L126 <detekt.NewLineAtEndOfFile>
The file /github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt is not ending with a new line.
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:126:2: warning: The file /github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt is not ending with a new line. (detekt.NewLineAtEndOfFile)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L88 <detekt.MaxLineLength>
Line detected, which is longer than the defined maximum line length in the code style.
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:88:1: warning: Line detected, which is longer than the defined maximum line length in the code style. (detekt.MaxLineLength)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L4 <detekt.UnusedImports>
The import 'androidx.security.crypto.EncryptedFile' is unused.
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:4:1: warning: The import 'androidx.security.crypto.EncryptedFile' is unused. (detekt.UnusedImports)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L23 <detekt.UnusedPrivateMember>
Private function `store` is unused.
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:23:41: warning: Private function `store` is unused. (detekt.UnusedPrivateMember)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt#L70 <detekt.UnusedPrivateMember>
Private function `read` is unused.
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorage.kt:70:41: warning: Private function `read` is unused. (detekt.UnusedPrivateMember)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt#L1 <detekt.FinalNewline>
File must end with a newline (\n)
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt:1:1: warning: File must end with a newline (\n) (detekt.FinalNewline)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt#L3 <detekt.SpacingAroundColon>
Missing spacing before ":"
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt:3:31: warning: Missing spacing before ":" (detekt.SpacingAroundColon)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt#L4 <detekt.SpacingAroundColon>
Missing spacing before ":"
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt:4:38: warning: Missing spacing before ":" (detekt.SpacingAroundColon)
github-actions / detekt
[detekt] modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt#L7 <detekt.SpacingAroundColon>
Missing spacing before ":"
Raw output
/github/workspace/modules/storage/src/main/kotlin/edu/stanford/spezi/modules/storage/local/LocalStorageError.kt:7:43: warning: Missing spacing before ":" (detekt.SpacingAroundColon)