Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 6 Compatibility #12

Merged
merged 8 commits into from
Jul 12, 2024
Merged

Swift 6 Compatibility #12

merged 8 commits into from
Jul 12, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jul 1, 2024

Fix Swift Concurrency

♻️ Current situation & Problem

Updates the flag name.

⚙️ Release Notes

  • Update swift concurrency flag name.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.79%. Comparing base (3326fea) to head (6c8e5f0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   81.14%   81.79%   +0.65%     
==========================================
  Files          11       11              
  Lines         281      280       -1     
==========================================
+ Hits          228      229       +1     
+ Misses         53       51       -2     
Files Coverage Δ
Sources/SpeziFoundation/Misc/TimeoutError.swift 60.00% <100.00%> (ø)
...ces/SpeziFoundation/Semaphore/AsyncSemaphore.swift 71.54% <65.91%> (+1.25%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3326fea...6c8e5f0. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg for fixing this!

Seems like we have a small amount of warnings (only in the tests) that will be errors in Swift 6 that surface as part of enabling this in this PR. Would be great to address them as part of this PR.

@PSchmiedmayer PSchmiedmayer added enhancement New feature or request bug An unexpected problem labels Jul 1, 2024
@PSchmiedmayer PSchmiedmayer linked an issue Jul 1, 2024 that may be closed by this pull request
1 task
@Supereg Supereg changed the title Fix Swift Concurrency Swift 6 Compatibility Jul 11, 2024
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool; thank you @Supereg!

@Supereg Supereg merged commit 4781d96 into main Jul 12, 2024
13 checks passed
@Supereg Supereg deleted the fix/strict-concurrency branch July 12, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Complete Concurrency Checking
2 participants