-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LLM Functionality from Package #24
Conversation
# Conflicts: # Package.swift # Sources/SpeziFHIRLLM/FHIRInterpretation/MultipleResources/FHIRGetResourceLLMFunction.swift # Sources/SpeziFHIRLLM/FHIRInterpretation/MultipleResources/FHIRMultipleResourceInterpreter.swift # Sources/SpeziFHIRLLM/FHIRInterpretation/SingleResource/FHIRResourceInterpreter.swift # Sources/SpeziFHIRLLM/FHIRInterpretationModule.swift # Sources/SpeziFHIRLLM/FHIRProcessor/FHIRResourceProcessor.swift # Sources/SpeziFHIRLLM/FHIRSummary/FHIRResourceSummary.swift # Sources/SpeziFHIRLLM/Settings/FHIRPrompt.swift # Tests/UITests/UITests.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
- Coverage 40.68% 33.50% -7.18%
==========================================
Files 20 21 +1
Lines 1207 1466 +259
==========================================
Hits 491 491
- Misses 716 975 +259
Continue to review full report in Codecov by Sentry.
|
We've decided to remove the LLM functionality from @philippzagar I saw your changes in #23. I have transferred them over into Feel free to review this pull request, however, it should only remove "application logic" 💯 |
@LeonNissen Like with the SpeziChat PR, the commits aren’t properly signed, which might cause a problem later on when we try to merge them. How do we plan to support applications that depend on SpeziFHIR and the current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philippzagar We discussed it and there will be a need for a dedicated module & package for that type of functionality in the long run. The placement in SpeziFHIR is not ideal and as we move to tagging a 1.0 for this package we need to further define its scope & focus. For now, removing the LLM parts will help us to clean things up. The elements are better positioned in the relevant apps or a dedicated package.
@PSchmiedmayer 100% agree, the SpeziFHIRLLM target was always intended as a kind of dumping ground for all FHIR-related LLM functionality, therefore less than ideal. |
Remove LLM Functionality from Package
♻️ Current situation & Problem
Remove the LLM summary and interpretation logic from this package, as it uses application-specific functionality that does not belong within the package
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: