Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LLM Functionality from Package #24

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

LeonNissen
Copy link
Contributor

@LeonNissen LeonNissen commented Dec 11, 2024

Remove LLM Functionality from Package

♻️ Current situation & Problem

Remove the LLM summary and interpretation logic from this package, as it uses application-specific functionality that does not belong within the package

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Leon Nissen added 4 commits November 18, 2024 14:21
# Conflicts:
#	Package.swift
#	Sources/SpeziFHIRLLM/FHIRInterpretation/MultipleResources/FHIRGetResourceLLMFunction.swift
#	Sources/SpeziFHIRLLM/FHIRInterpretation/MultipleResources/FHIRMultipleResourceInterpreter.swift
#	Sources/SpeziFHIRLLM/FHIRInterpretation/SingleResource/FHIRResourceInterpreter.swift
#	Sources/SpeziFHIRLLM/FHIRInterpretationModule.swift
#	Sources/SpeziFHIRLLM/FHIRProcessor/FHIRResourceProcessor.swift
#	Sources/SpeziFHIRLLM/FHIRSummary/FHIRResourceSummary.swift
#	Sources/SpeziFHIRLLM/Settings/FHIRPrompt.swift
#	Tests/UITests/UITests.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 259 lines in your changes missing coverage. Please review.

Project coverage is 33.50%. Comparing base (d368a1e) to head (961b287).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../SpeziFHIR/Extensions/FHIRResource+Flattener.swift 0.00% 258 Missing ⚠️
...urces/SpeziFHIRHealthKit/FHIRStore+HealthKit.swift 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   40.68%   33.50%   -7.18%     
==========================================
  Files          20       21       +1     
  Lines        1207     1466     +259     
==========================================
  Hits          491      491              
- Misses        716      975     +259     
Files with missing lines Coverage Δ
...urces/SpeziFHIRHealthKit/FHIRStore+HealthKit.swift 0.00% <0.00%> (ø)
.../SpeziFHIR/Extensions/FHIRResource+Flattener.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d368a1e...961b287. Read the comment docs.

@LeonNissen
Copy link
Contributor Author

We've decided to remove the LLM functionality from SpeziFHIR and move it over to the application.

@philippzagar I saw your changes in #23. I have transferred them over into LLMonFHIR in: StanfordBDHG/LLMonFHIR#53

Feel free to review this pull request, however, it should only remove "application logic" 💯

@philippzagar
Copy link
Member

@LeonNissen Like with the SpeziChat PR, the commits aren’t properly signed, which might cause a problem later on when we try to merge them.

How do we plan to support applications that depend on SpeziFHIR and the current SpeziFHIRLLM target functionality, such as LLMonFHIR and OwnYourData? Probably you and @PSchmiedmayer already have a plan there? Maybe a separate SPM package as a whole?

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippzagar We discussed it and there will be a need for a dedicated module & package for that type of functionality in the long run. The placement in SpeziFHIR is not ideal and as we move to tagging a 1.0 for this package we need to further define its scope & focus. For now, removing the LLM parts will help us to clean things up. The elements are better positioned in the relevant apps or a dedicated package.

@PSchmiedmayer PSchmiedmayer merged commit a2e68a2 into main Dec 12, 2024
6 of 8 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feature/remove-fhir-llm branch December 12, 2024 01:23
@philippzagar
Copy link
Member

@PSchmiedmayer 100% agree, the SpeziFHIRLLM target was always intended as a kind of dumping ground for all FHIR-related LLM functionality, therefore less than ideal.
Great to see that improve 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants