-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lift to SpeziLLM #17
Lift to SpeziLLM #17
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
- Coverage 42.87% 39.95% -2.92%
==========================================
Files 26 20 -6
Lines 1297 1154 -143
==========================================
- Hits 556 461 -95
+ Misses 741 693 -48
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see the updates moving to Spezi FHIR. I only had one comment about the change of coaching. Once this is resolved and the upstream PR is merged it would be great to see this merged as well 👍
@PSchmiedmayer PR is ready to merge, as the test coverage decreased a bit, please force merge the PR! (we can also do that within our meeting tomorrow!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements @philippzagar; I only had a few smaller comments, we can discuss them in our meeting tomorrow morning 👍
Sources/SpeziFHIRLLM/FHIRInterpretation/MultipleResources/FHIRGetResourceLLMFunction.swift
Show resolved
Hide resolved
Sources/SpeziFHIRLLM/FHIRInterpretation/MultipleResources/FHIRMultipleResourceInterpreter.swift
Show resolved
Hide resolved
@philippzagar I'll finish the localizations after our meeting! |
@PSchmiedmayer Please force merge the PR, as discussed in our meeting :) |
Lift to SpeziLLM
♻️ Current situation & Problem
Dependent on old version of SpeziLLM
⚙️ Release Notes
📚 Documentation
Proper docs included
✅ Testing
All tests passing
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: