Support configure()
call on services and expose BluetoothScanner via APISupport SPI
#50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
configure()
call on services and expose BluetoothScanner via APISupport SPI♻️ Current situation & Problem
Currently it is not possible for a
BluetoothService
implementation to provide steps for configuration (e.g., set up onChange handlers). Only theBluetoothDevice
has aconfigure()
method that can be used for these use cases. This PR adds a newconfigure()
method toBluetoothService
s such that their logic can be self-contained.Additionally, the
scanNearbyDevices
has really useful logic for Bluetooth Scanners that was previously (< 2.0) accessible in the public interface, but is exclusively accessible to theBluetooth
module and theBluetoothManager
. This PR exposes these interfaces as theAPISupport
SPI. This allows other library developers to reuse thescanNearbyDevices
modifier for their custom Bluetooth scanner implementations (e.g., Muse SDK in NAMS).⚙️ Release Notes
configure()
method to theBluetoothService
protocol to allow for self-container bluetooth service implementations.BluetoothScanner
.📚 Documentation
Added documentation for newly exposed symbols.
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: