Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SMP Support #9

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Adding SMP Support #9

merged 1 commit into from
Jan 18, 2023

Conversation

tuxfan
Copy link
Contributor

@tuxfan tuxfan commented Jan 17, 2023

  • Adds configuration file for smp.

- Adds configuration file for `smp`.
@bonachea
Copy link
Contributor

I have a comment/question for @elliottslaughter @streichler which applies to all of these config files (including the one being added here).

Some of the configure options reflected in these files are obsolescent, in some cases for over 5 years now.
What is the oldest version of GASNet that Realm (and more specifically repo) are trying to support?

I see the repo currently contains GASNet versions dating back to GASNet-1.30.0.tar.gz which was released in 2017, are you actually trying to support running with 6-year old GASNet? If so, why?

FWIW our general GASNet support policy is to support EX releases up to 2 years in age, and GASNet-1 release packages are no longer supported at all (the GASNet-1 API remains supported in EX). We always strongly encourage use of the latest release of GASNet-EX (absent a good reason, such as tracking a regression or attempting to run on EOL hardware).

CC: @PHHargrove

@elliottslaughter
Copy link
Contributor

In my thread on this topic users reported using GASNet 1.32.0 (actively, for Quartz at LLNL) and 2021.3.0 (this was for a paper, so no longer active use, but possibly of interest for improving or replicating results).

We have no formal deprecation policy but I was going to prune versions older than that, and if there's some newer target we should be aspiring to, it would be good to let us know. Most of our users probably take the default, which we pin to (usually) the newest version, typically within a couple months from release. E.g., right now it's 2022.9.2.

@elliottslaughter
Copy link
Contributor

If we take (say) 1.32.0 and 2021.3.0 as a floor (for now), what options could we prune?

@elliottslaughter
Copy link
Contributor

For what it's worth, I did the removals suggested above. If you think it's appropriate to do more, let us know.

@bonachea
Copy link
Contributor

bonachea commented Jan 17, 2023

@elliottslaughter said:

using GASNet 1.32.0 (actively, for Quartz at LLNL)

IIUC from public documentation LLNL Quartz is Omni-Path, which is directly supported by GASNet-EX starting in version 2022.3.0. So I'd highly recommend re-evaluating this use case, as they probably can/should upgrade to the latest GASNet-EX. There have been numerous performance and stability improvements in ofi-conduit in the past 5 years since 1.32.0 was released, as it's now the flagship conduit for the HPW Cray EX line.

One caveat is that Cornelis (who now owns the Omni-Path IP) is actively developing a new OPX provider, which AFAIK is not yet supported by ANY version of GASNet (due to missing provider capabilities and related defects). So if Quartz is running the Cornelis driver they might be unable to run any version of GASNet ofi-conduit (yet), although we have an active dialog with Cornelis to close this gap. (I say "might" because if the PSM2 provider remains functional then that might "just work" with GASNet-EX 2022.3.0+).

2021.3.0 (this was for a paper, so no longer active use, but possibly of interest for improving or replicating results).

I agree that reproducing old published results is a worthwhile use case. However I'd respectfully submit that such a use case should probably use old versions of the ENTIRE software stack (including the then-current version of this repo). IOW git never forgets, and if you tag the version of this repo that was current for 2021.3.0, then using that tag is probably the most reliable way to reproduce results.

@bonachea
Copy link
Contributor

If we take (say) 1.32.0 and 2021.3.0 as a floor (for now), what options could we prune?

Those two releases differ in time by 2.5 years, so the answer strongly depends on whether we can in fact drop 1.32. Once you're certain what's being kept I can provide a more accurate answer.

@elliottslaughter
Copy link
Contributor

Thanks. I'll move remaining discussion of obsolete versions to a new issue.

@elliottslaughter
Copy link
Contributor

@bonachea Do you have any concerns about the content of this PR, aside from flags that we'd be able to clean up by removing older GASNet versions? (Which we can do independently of this particular PR.)

@bonachea
Copy link
Contributor

@elliottslaughter no concerns about this PR in particular. Apologies for the tangential discussion, as you say we can pursue that in issue #10

@elliottslaughter elliottslaughter merged commit b0ea9bd into StanfordLegion:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants