Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify PAT and submodule inputs for checkout action #29

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Sep 19, 2023

Add ability to specify PAT and submodule inputs for checkout action

♻️ Current situation & Problem

Currently, it is not possible to modify the behavior of the actions/checkout step of the xcodebuild-or-fastlane workflow. This might be desired for more custom project setup where, e.g., submodules should be checked out.

💡 Proposed solution

This PR adds two new inputs to the xcodebuild-or-fastlane workflow to allow specifying the token and submodules option of the checkout actions to allow (1) automatic checkout of submodules and (2) allow checkout of private submodules.

⚙️ Release Notes

  • Added checkout_token and checkout_submodules inputs for the xcodebuild-or-fastlane workflow.

➕ Additional Information

Related PRs

Testing

This action run verifies functionality of the updated action. The codeql job still runs without issue by not providing any of the new inputs and the buildandtest job successfully fetches the submodule using the provided PAT.

Reviewer Nudging

This setup was tested to work in the above mentioned scenario. Here is the workflow file for this workflow run.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg, looks good to me 👍

@Supereg Supereg merged commit 9e1fc1f into main Sep 19, 2023
1 check passed
@Supereg Supereg deleted the feature/submodule-checkout branch September 19, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants