Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qualtrics integration preliminary #159

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Qualtrics integration preliminary #159

wants to merge 8 commits into from

Conversation

cheejung
Copy link
Contributor

Description

Related Issue

TrafficCop
TrafficCop requested changes May 23, 2024
View reviewed changes
wearipedia/devices/qualtrics/qualtrics.py Outdated Show resolved Hide resolved
wearipedia/devices/qualtrics/qualtrics_fetch.py Show resolved Hide resolved
wearipedia/devices/qualtrics/qualtrics_gen.py Outdated Show resolved Hide resolved
TrafficCop
TrafficCop requested changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@TrafficCop TrafficCop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring format should match other devices

TrafficCop
TrafficCop reviewed Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@TrafficCop TrafficCop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question on synthetic data generator design.

wearipedia/devices/qualtrics/qualtrics_gen.py Show resolved Hide resolved
TrafficCop
TrafficCop requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@TrafficCop TrafficCop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Run make check-codestyle (few import style changes required)
  2. Since you are adding some new packages here (qualtricsAPI), run "make install" and then commit the updated requirements.txt as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrafficCop TrafficCop TrafficCop requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheejung @TrafficCop