fix links in agenda page

[koilebeit]

Pull request

Proposed changes

fixes #149

Types of changes

• New feature (non-breaking change which adds functionality).
• Enhancement (non-breaking change which enhances functionality)
• Bug Fix (non-breaking change which fixes an issue).
• Breaking change (fix or feature that would cause existing functionality to change).

Checklist

• I have read the README document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

Summary by CodeRabbit

• New Features
  • Enhanced external links in the agenda section to open in new tabs with improved security attributes.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 13ce76c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The update involves enhancing user experience and security for external links on the Agenda page by ensuring they open in new tabs and include rel="noopener nofollow" attributes for better security and SEO practices.

Changes

File Path	Change Summary
src/routes/agenda/+page.svelte	Added target="_blank" and rel="noopener nofollow" to external links in this file.

Assessment against linked issues

Objective	Addressed	Explanation
Add target="_blank" to external links to open them in new windows (#149)	✅
Add rel="noopener nofollow" to external links for security (#149, #21)	✅

Possibly related issues

• add nofollow and target=_blank to external links in navbar forschung.stadtgeschichtebasel.ch#21: This issue's objectives to add rel="nofollow" and target="_blank" to external links in the navbar are partially addressed here for a different section (Agenda page), suggesting a similar update might be beneficial for the navbar.

Poem

🐇💻
In the web's vast meadow, under the digital sky,
Links like little gateways, bid the old page goodbye.
With a hop and a click, in a new tab, they bloom,
Safe from the prowlers, in their snug, new room.
Oh, how the users dance, with joy, they twirl,
Thanks to the tiny, wise code changes by a diligent rabbit. 🌟

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between c71c4cb and 13ce76c.

Files selected for processing (1)

• src/routes/agenda/+page.svelte (1 hunks)

Additional comments not posted (2)

src/routes/agenda/+page.svelte (2)

214-214: Ensure consistency in the use of rel attribute across all external links.

Consider adding noopener noreferrer to all external links to ensure consistency and enhance security. This is especially important to prevent the newly opened page from being able to access the window object of the page that opened it.

---

222-226: Good addition of target="_blank" and rel="noopener nofollow" to improve user experience and security.

This change correctly implements the desired functionality of opening external links in new tabs and includes rel="noopener nofollow" for security. This is a direct response to the issue raised in #149 and enhances the site's usability.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.