Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bionic/el7 and add el9 #187

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Remove bionic/el7 and add el9 #187

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6c1bec
Remove bionic/el7 and add el9
amanda11 Feb 26, 2024
2b9ce9b
Add changelog
amanda11 Feb 26, 2024
612e8ad
try and fix ruby
amanda11 Feb 26, 2024
79b51e0
Add el9 to docker file
amanda11 Feb 26, 2024
12fd3e3
EL9 has to use nodejs 18 or above
amanda11 Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ jobs:
machine:
image: "ubuntu-2004:current"
working_directory: ~/StackStorm/st2chatops
parallelism: 4
parallelism: 3
shell: /bin/bash --login
environment:
DISTROS: bionic focal el7 el8
DISTROS: focal el8 el9
ST2_PACKAGES_REPO: https://github.com/StackStorm/st2-packages
ST2_TEST_ENVIRONMENT: https://github.com/StackStorm/st2-docker
DEPLOY_PACKAGES: 1
Expand All @@ -38,7 +38,6 @@ jobs:
docker-compose version
nodejs -v
jq --version
package_cloud version
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of package_cloud version intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting an error with not found - so just trying to debug it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving PR into draft whilst I get the circleCI to pass...
This is the only repo that uses the package_cloud.sh that had that package_cloud version call - so just seeing what's going on...

- run:
name: Ensure Docker running
command: 'sudo docker info >/dev/null 2>&1 || sudo service docker start; '
Expand Down Expand Up @@ -122,7 +121,7 @@ jobs:
- image: circleci/ruby:2.7
working_directory: ~/packages
environment:
DISTROS: "bionic focal el7 el8"
DISTROS: "focal el8 el9"
steps:
- attach_workspace:
at: /home/circleci
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ Changed

Contributed by @lopf

* Added support for EL9. Removed support for EL7 and bionic. #187
Contributed by @amanda11

Removed
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* Remove skills-validator from npm-shrinkwrap.json
Expand Down