Uncomment [webui] section in st2.conf #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76.54% (diff: 100%)@@ master #3040 diff @@
==========================================
Files 430 430
Lines 21962 21962
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 16791 16809 +18
+ Misses 5171 5153 -18
Partials 0 0
|
|
Thanks. It doesn't seem to break tests so I will go ahead and merge it. Will also verify locally it doesn't cause issues with dev environment (it shouldn't, but you never know). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported in #community.
User uncommented only
webui_base_url = https://mywebhost.domainwithout uncommenting[webui]section, ex:See: StackStorm/hubot-stackstorm#129 (comment)
With this small change it looks safer, more obvious and less error-prone default.