-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce jsonschema requirements to allow 3.2 #251
Conversation
test it |
Try retriggerring by closing/reopening |
The 3.6 tests are failing due to pep8 failing but that seems unrelated to my change -
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. I will try and get this pushed this week after I debug the unit test failure.
@guzzijones makes sense to revive this PR? I'm guessing the dependency update might be helpful here. |
@@ -1,7 +1,7 @@ | |||
chardet>=3.0.2,<4.0.0 | |||
eventlet | |||
Jinja2>=2.11 # BSD License (3 clause) | |||
jsonschema!=2.5.0,<3.0.0,>=2.0.0 # MIT | |||
jsonschema!=2.5.0,>=2.0.0,<=3.2 # MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with <3.2
the PR really installed 3.1.1
version. Updated the requirements so it really installs 3.2.0
The project I'm working on has a hard requirement of jsonschema 3.2 so currently, we have to use a horrible workaround to utilise st2, I'm hoping to remove this conflict.