Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node 20 #232

Closed
wants to merge 9 commits into from
Closed

Conversation

rebrowning
Copy link
Contributor

@rebrowning rebrowning commented Dec 16, 2023

Upgrade to node 20, had to rewrite the gulp file to allow myself to run the tests with the newer version. Upgraded other libraries that did not cause unittests to break.

Ran the st2chatops repo with this package and am successfully able to use a slackbot, so I will consider these changes working (going to also open a PR

@rebrowning rebrowning closed this Dec 16, 2023
@rebrowning rebrowning deleted the upgrade_node_20 branch December 16, 2023 07:39
@rebrowning rebrowning restored the upgrade_node_20 branch December 16, 2023 07:40
@nzlosh
Copy link
Contributor

nzlosh commented Dec 17, 2023

As a side note: err-stackstorm is a Python chatops implementation. If you're interested, you can read more about it here https://err-stackstorm.readthedocs.io/en/latest/

@rebrowning
Copy link
Contributor Author

As a side note: err-stackstorm is a Python chatops implementation. If you're interested, you can read more about it here https://err-stackstorm.readthedocs.io/en/latest/

unfortunately this is about upgrading the package itself so that a more modern version of nodejs can be used (bringing it in line with node 20). Switching to a different chatops implementation is not an option.

@rebrowning rebrowning reopened this Dec 19, 2023
@nzlosh
Copy link
Contributor

nzlosh commented Jan 8, 2024

@rebrowning Tests have been switched from TravisCI to Github Actions which targets nodejs 14 to 20. The tests are passing on master, but fail on your branch.

@rebrowning
Copy link
Contributor Author

@nzlosh I'm going to open another PR #234 to see if we can do without most of these changes and upgrades. I did this PR first but then st2chatops essentially just needed coffeescript pinned, so I'll see if that works here as well.

@rebrowning rebrowning closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants