-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(list): enhance rich text list editing experience #298
Conversation
✅ Deploy Preview for stacks-editor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected (with one very minor quirk noted below) and the code seems reasonable. Thanks for taking care of this @giamir.
Noting one minor quirk
Note
For the record, I don't think this behavior is significant or worth handling, so I don't suggest any changes to this PR.
I took the testing instructions in the PR description very literally and ran into an unexpected behavior.
I added three items (and nothing else), I then selected them all with either ⌘ + a
or by clicking and dragging across all of them, and then entered either ⌘ + u
or clicked the bullet list button. I then entered either ⌘ + u
or clicked the bullet list button again and saw the bullet list get nested inside a new bullet list.
This only seems to happen when all of the contents of the editor are selected. I imagine this circumstance is probably rare and is not an edge case worth handling, but felt like it was worth noting.
I noticed this as well. This happen only if you select all the content. I agree with you we can consider this a rare edge case for now. Also I noticed that similar odd issues also happen with other commands when selecting all the content. Probably something that should be tackled in a separate PR anyway (not related to these changes). Thanks for the review. 🎉 |
This PR enhance the editor rich text experience when editing lists.
For more context about the issue see also this document.
How to test
Part 1:
Item 1
thenEnter
,Item 2
thenEnter
and so on)Meta+u
)Meta+u
)Meta+o
)Part 2:
All tests and linters should pass.
STACKS-534