Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always perform "last read" check in heartbeat when HeartbeatConsistencyChecks is enabled #2795

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Always perform "last read" check in heartbeat when HeartbeatConsistencyChecks is enabled #2795

merged 2 commits into from
Sep 10, 2024
+5 −2

Commits on Sep 10, 2024

  1. PhysicalBrdige: Always perform "last read" check in heartbeat 

    When we have slowly adding things to the heartbeat (originally intended just to send data to keep connections alive) like detecting connection health, the if/else has gotten more complicated. With the addition of `HeartbeatConsistencyChecks`, we prevented some fall throughs to later checks which means that if that option is enabled, we were no longer detecting dead sockets as intended.

This is a tactical fix for the combination, but I think overall we should look at refactoring how this entire method works because shoehorning these things into the original structure/purpose has been problematic several times.
    @NickCraver
    NickCraver committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    fb47f20 View commit details
    Browse the repository at this point in the history

  2. Add release notes

    @NickCraver
    NickCraver committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    77b695e View commit details
    Browse the repository at this point in the history