Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCN-413] Upgrade to .NET 8 #22

Merged
merged 12 commits into from
Dec 17, 2024
Merged

Conversation

WouterDeKort
Copy link

@WouterDeKort WouterDeKort commented Dec 16, 2024

This PR upgrades OpServer to .NET 8 and all packages to the latest supported version.

This completely removes any reference to System.Data.SqlClient.

Here is a successfull Octopus deploy to https://opserver.ascn-dev.int.gcp.stackoverflow.net/.

I've manually tested the Exceptions and SQL modules in OpServer and everything looks good.

@WouterDeKort WouterDeKort changed the title [ASCN-413] Remove System.Data.SqlClient [ASCN-413] Upgrade to .NET 8 Dec 16, 2024
@WouterDeKort WouterDeKort added the deploy-to-ascn-dev automatically deploy this pr to ascn-dev label Dec 16, 2024
@WouterDeKort WouterDeKort requested review from a team and stephen-vakil December 16, 2024 14:36
@WouterDeKort WouterDeKort marked this pull request as ready for review December 16, 2024 14:38
@WouterDeKort WouterDeKort requested a review from mukunku December 16, 2024 16:11
Copy link

@mukunku mukunku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through the code changes everything makes sense to me 👍🏼 Thanks for putting this together. Apps that use OpServer will need to update their refs separately I presume?

@WouterDeKort WouterDeKort merged commit f28cddb into main Dec 17, 2024
5 checks passed
@WouterDeKort WouterDeKort deleted the wdekort/removesystemdatasqlclient branch December 17, 2024 08:40
@WouterDeKort
Copy link
Author

Looking through the code changes everything makes sense to me 👍🏼 Thanks for putting this together. Apps that use OpServer will need to update their refs separately I presume?

What refs do you mean? The one to Exceptional? I've been doing that for all the apps I update to .NET 8/Microsoft.Data.SqlClient. Or are there other refs I'm missing?

@mukunku
Copy link

mukunku commented Dec 17, 2024

Looking through the code changes everything makes sense to me 👍🏼 Thanks for putting this together. Apps that use OpServer will need to update their refs separately I presume?

What refs do you mean? The one to Exceptional? I've been doing that for all the apps I update to .NET 8/Microsoft.Data.SqlClient. Or are there other refs I'm missing?

Ah yes, I was thinking of Exceptional. Thanks 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-to-ascn-dev automatically deploy this pr to ascn-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants