Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCN-382] Split secrets for Exceptional and Status #18

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

WouterDeKort
Copy link

@WouterDeKort WouterDeKort commented Nov 14, 2024

This PR is for ASCN-382.

DBRE uses two sets of credentials for OpServer:

This PR adds a second set of secrets and splits the Sql secrets we use for Exceptional and Sql Status so we can configure this correctly in prod. For ascn-dev, I added the required secrets and deployed successfully from local CNAB.

I also asked Aaron if each app should have its own Exceptional credentials here since I think we now share the db-Exceptions-User between all apps and I don't think that's correct.

@WouterDeKort WouterDeKort changed the title Bump chart version [ASCN-382] OpServer to Prod Nov 14, 2024
@WouterDeKort WouterDeKort changed the title [ASCN-382] OpServer to Prod [ASCN-382] Split secrets for Exceptional and Status Nov 14, 2024
@WouterDeKort WouterDeKort requested review from a team and stephen-vakil November 14, 2024 10:45
@WouterDeKort WouterDeKort marked this pull request as ready for review November 14, 2024 10:49
stephen-vakil
stephen-vakil previously approved these changes Nov 14, 2024
Copy link

@stephen-vakil stephen-vakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified locally with docker; looks correct and works

@stephen-vakil stephen-vakil merged commit 878982e into main Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants