Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCN-375] Setup Serilog and Kubernetes console logging #15

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

WouterDeKort
Copy link

@WouterDeKort WouterDeKort commented Oct 31, 2024

This PR is for ASCN-375.

This PR adds Serilog and configures the app so exceptions that go to Exceptional are also logged to the console. This allows us to see the errors in DataDog.

@WouterDeKort WouterDeKort marked this pull request as draft October 31, 2024 13:35
@WouterDeKort WouterDeKort marked this pull request as ready for review October 31, 2024 15:34
Copy link

@juanrodriguezcen juanrodriguezcen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@stephen-vakil stephen-vakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested/verified locally

@stephen-vakil stephen-vakil merged commit 4557744 into main Oct 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants