Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCN-227] Add support for Reloader in Kubernetes #13

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

WouterDeKort
Copy link

@WouterDeKort WouterDeKort commented Oct 25, 2024

This PR is for ASCN-227 and does the exact same thing as this Scheduler PR.

This PR follows these instructions to add the annotation to enable Reloader to the deployment. Reloader is already installed in the Kubernetes cluster by SRE. By having this annotation, Kubernetes will make sure pods are restarted when a secret or config map changes.

How to test

  1. Deploy this PR to ascn-dev through local CNAB
  2. Open the ascn-dev cluster in Lens and go to the OpServer namespace. There should be 1 pod that has been running for a while
  3. Change the deployment replica to 3
  4. Change the external secret refresh to 1s (so you don't have to wait 5 minutes after changing the GCP secret)
  5. Edit the Okta Client Id secret in GCP here to my_okta_secret
  6. Kubernetes will auto create new pods 1 by 1 until all 3 pods are replaced
  7. Revert the secret change

Copy link

@stephen-vakil stephen-vakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified/tested in dockerdesktop. works well!

@WouterDeKort WouterDeKort merged commit efeda64 into main Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants