Add option to do stratified sampling for few-shot examples #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrorii
changed the title
mrorii
requested review from
mkshing and
polm-stability
and removed request for
jon-tow
polm-stability
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Looks good!
The sampling logic here is tricky, especially the way rounding is handled, but working through some examples it seems OK to me. (This would be a great place for unit testing but I wouldn't want to introduce it right now with the way the code base is...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR does the following:
Details
Note that the base branch for this PR is set to(EDIT: the base branch is nowuse-japanese-prompt-for-jnliwhich corresponds to #110jp-stableas #110 has been merged), as both #110 and this PR updates the task version for JNLI.