Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRD-95 Implement "string contains" approach for jaqket_v2 and jsquad #108

Closed
wants to merge 1 commit into from

Conversation

mrorii
Copy link

@mrorii mrorii commented Oct 16, 2023

LLMs can sometimes provide correct answers but that may not be an exact match to the ground truth.
In order to account for this, in addition to the existing "exact match" approach, this PR adds a new "string contains" approach. For example, this is done by LINE corporation (https://logmi.jp/tech/articles/325454):

正解かどうかの判定は、出力結果の一部に正解が内包されているかどうかで判定しています。

@mrorii mrorii self-assigned this Oct 16, 2023
@mrorii mrorii changed the title JRD-95: Implement "string contains" approach for jaqket_v2 and jsquad JRD-95 Implement "string contains" approach for jaqket_v2 and jsquad Oct 16, 2023
@mrorii
Copy link
Author

mrorii commented Oct 24, 2023

Closing this for now as we decided that using the existing F1 instead of string contains is better, in order to penalize very long/redundant answers even if it's correct

@mrorii mrorii closed this Oct 24, 2023
@mrorii mrorii deleted the JRD-95 branch October 24, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant