-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a bug for prompt version 0.6
in jaqket_v2
#105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
(I guess many implementations of preprocess_ctx
are a bit repetitive so hopefully we can make it a bit more DRY in the future, but that's definitely out-of-scope for this PR)
@mrorii yeah, I agree... |
This looks like the same issue as #80, but with a different task/prompt. The code here should work and looks similar to existing code in other prompts, but honestly I find the use of recursion really confusing and hard to follow, so I would recommend a solution like in #80. It's also fine as-is though. |
@polm-stability thank you for your review! I fixed it based on your comment. Could you review this again? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for cleaning it up!
jaqket_v2-0.2-0.6
with 1-shot gets the following value error. This PR solves this error.Please note that I just used the very small model
pretrained=rinna/japanese-gpt2-xsmall
for quick debug.