-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add training materials from NE BRR 2023 docker training #903
Conversation
|
updating fork to be in sync with upstream staphb docker-builds repo
@erinyoung FYI I'm using this PR to also add a "Training" section to the main readme with links to the materials included with this PR. This would be a good location to link to the training you led through APHL: https://learn.aphl.org/learn/course/external/view/elearning/355/intermediate-docker-bioinformatics-workshop We could include as part of this PR or perhaps add in a separate one. Happy to hear your feedback/thoughts on this. |
Closes #1044 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding this, @kapsakcj.
One quick note on something I found interesting: I like that you've updated it to checkout master
to be more specific, though it seems that the current .gitpod.yml also sets the environment to master by default and may just ignore that checkout main
line as there is no main
branch to checkout.
You are correct, it's smart enough to know which branch to check out, but the change in this PR just eliminates the error or warning (can't remember which) that occurs upon starting the gitpod environment |
Setting as a draft for now, since I'd like to add links to the training materials on the main/README.md
but wanted to at least get the ball rolling on this PR. Will mark ready for review once that is completed.I realized we never PR'd this back to the main StaPH-B repo.
@kevinlibuit I would like to get your eyes on these training materials before merging. Happy to make edits where you see necessary.
This PR does the following:
.gitpod.yml
folder togit checkout master
instead ofmain
which resolves the issue of checking out the repo upon launching the GitPod (see screenshot of GitPod workspace I just spun up)Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)