Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mlst DB for August 2023 #710

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

cimendes
Copy link
Contributor

Motivation

This PR updates mlst version 2.23.0 with the latest database available from pubmlst as of August 2023. Additionally, the README file is now saved into the container for traceability.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@kapsakcj kapsakcj self-requested a review August 21, 2023 15:14
@kapsakcj
Copy link
Collaborator

Thanks for the PR. Nice to have updated databases for this tool 👍

Image builds successfully and the test output looks good too.

I'll merge this and deploy under the docker image name & tag: staphb/mlst:2.23.0-2023-08 to stick with the previous convention. I'll also overwrite the latest tag

@kapsakcj kapsakcj merged commit 42fb817 into StaPH-B:master Aug 21, 2023
2 checks passed
@kapsakcj
Copy link
Collaborator

you can view the status of the deploy workflow here: https://github.com/StaPH-B/docker-builds/actions/runs/5928339054

should be available on dockerhub and quay.io in the next 20 min or so

@cimendes cimendes deleted the im-ts-mlst-update branch August 29, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants