Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add freyja 1.4.5 #709

Merged
merged 2 commits into from
Aug 23, 2023
Merged

add freyja 1.4.5 #709

merged 2 commits into from
Aug 23, 2023

Conversation

kapsakcj
Copy link
Collaborator

@kapsakcj kapsakcj commented Aug 17, 2023

This PR adds a dockerfile for freyja 1.4.5. This will close issue #708

Is anyone available to review today? I ask because freyja/1.4.5/README.md states that the docker image was built today. If no one is available to review, we'll need to update that file with the correct date and barcode version on line 22

Changes from previous dockerfile:

  • upgraded base image to mambaorg/micromamba:1.4.9 and changed LABEL to reflect this
  • updated ARG on line 5 with new freyja version

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@kapsakcj kapsakcj marked this pull request as ready for review August 17, 2023 16:53
@erinyoung erinyoung merged commit 9ae9ed0 into master Aug 23, 2023
2 checks passed
@erinyoung
Copy link
Contributor

erinyoung commented Aug 23, 2023

Thank you for your PR!

I didn't have any changes to recommend, so I have merge this PR and am deploying an image to Dockerhub and quay.

You can check the status of this deployment at https://github.com/StaPH-B/docker-builds/actions/runs/5954967386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants