-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add BUSCO 5.4.7 #701
add BUSCO 5.4.7 #701
Conversation
I used Focal as the base image to avoid Python errors on Jammy. Busco and other programs were not happy with later versions than Python 3.8. All functions of Busco work well on my tests. |
I added a test of running busco on a Salmonella genome and added the CMD layer.
It's looking good! All your tests work. The labels are all there. It's going to be a great tool for the community. What busco databases are included in this image? I have some editing requests:
|
I believe all issues are resolved. |
I think you have resolved all issues as well. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to
- merge this PR
- push to docker and quay using both the tag '5.4.7' and 'latest'
You can track the stage of deployment at https://github.com/StaPH-B/docker-builds/actions/runs/5787821276 |
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)