Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding freyja 1.4.4 #678

Merged
merged 3 commits into from
Jun 22, 2023
Merged

adding freyja 1.4.4 #678

merged 3 commits into from
Jun 22, 2023

Conversation

erinyoung
Copy link
Contributor

There's a new version of freyja out!

This one has some plot bug fixes and different methods for covariants (https://github.com/andersen-lab/Freyja/releases/tag/v1.4.4).

I just copied the files from 1.4.3 to 1.4.4. I think the tag for this one would be 1.4.4 and would replace the 'latest' tag on dockerhub and quay.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung
Copy link
Contributor Author

This PR is ready to review and should close #684

@kapsakcj
Copy link
Collaborator

hoping to review later today, sorry for the delay

@kapsakcj kapsakcj self-requested a review June 22, 2023 15:00
@kapsakcj
Copy link
Collaborator

Everything looks great, thanks for your patience. I made some minor adjustments to the dockerfile & freyja-specific README.md to document the included version of the barcodes file (as well as additional tools included in the image).

Once the tests pass, I will merge and deploy to dockerhub and quay with the tag :1.4.4 and overwrite the :latest tag

@kapsakcj
Copy link
Collaborator

Merging this PR will resolve issues #684 #655

@kapsakcj kapsakcj merged commit c454eb5 into master Jun 22, 2023
2 checks passed
@erinyoung erinyoung deleted the erin-freyja-1.4.4 branch June 22, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants